New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
property alwaysShowNavigationBar #18
base: master
Are you sure you want to change the base?
Conversation
@HBehrens Wow lots of code changes in there. I like the idea of SVActivity, although it should have been called SVWebViewControllerAction ;) The navigation bar stuff looks fine, but I really like the other changes as well so I'll try to review the whole thing shortly so I can merge the whole pull request. Thanks for the hard work! |
Hey Sam, any news on your side? I am currently working on a project that uses the SVWebViewController via CocoaPods and would love to go back to the official pod instead of using my gist https://gist.github.com/3100652 |
…ller into keepingUp Conflicts: SVWebViewController/SVWebViewController.m
…from samvermette/master) Conflicts: Demo/Classes/ViewController.m SVWebViewController/SVModalWebViewController.h SVWebViewController/SVWebViewController.m
Looking back, I think it would have been better to make this 2 separate pull requests. 1 for the |
as discussed in #8 I finally implemented the property
alwaysShowNavigationBar
(default: YES) to hide the navigation bar whenever you scroll down on an iPhone. Tested with rotation and half-way scrolled navigation bar.Note: The demo app actives this behavior in both cases.