Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LABEL_SELFREF enhancements #472

Merged
merged 1 commit into from
Nov 2, 2021
Merged

LABEL_SELFREF enhancements #472

merged 1 commit into from
Nov 2, 2021

Conversation

yakra
Copy link
Contributor

@yakra yakra commented Nov 2, 2021

* avoid false positives at U-turn ramps
* flag letter-suffixed routes after a slash
* optimize for speed
@yakra yakra added enhancement datacheck code organization data quality speed LABEL_SELFREF This is a temporary tag, as several open issues concern this specific datacheck. labels Nov 2, 2021
yakra added a commit to yakra/HighwayData that referenced this pull request Nov 2, 2021
@jteresco jteresco merged commit 59109ab into TravelMapping:master Nov 2, 2021
@jteresco
Copy link
Contributor

jteresco commented Nov 2, 2021

This will be used starting tonight, thanks!

@yakra
Copy link
Contributor Author

yakra commented Nov 2, 2021

Just took a look back at the datacheck page, specifically at CHL.
Most of what's there looks dubious:

chl.r005;R5_U1013S;;;LABEL_SELFREF;
chl.r005;R5_U1026S;;;LABEL_SELFREF;
chl.r005;R5_U1030S;;;LABEL_SELFREF;
chl.r005;R5_U1059S;;;LABEL_SELFREF;
chl.r005;R5_U294N;;;LABEL_SELFREF;
chl.r005;R5_U301N;;;LABEL_SELFREF;
chl.r005;R5_U311N;;;LABEL_SELFREF;
chl.r005;R5_U320N;;;LABEL_SELFREF;
chl.r005;R5_U328N;;;LABEL_SELFREF;

These are obviously right out, not following U-turn nomenclature.
I'll have to go back and make the holes in the net a bit smaller.

Then there's
chl.r005;R5_U559;;;LABEL_SELFREF;
which meets the standard except that there's no R5_U1 thru R5_U558.
These can be flagged, though it gets a bit more complicated. Most likely will involve a new datacheck code.

@yakra
Copy link
Contributor Author

yakra commented Nov 2, 2021

  • What happens with labels ending in an underscore?
    IndexError. Putting in a try/except condition for these rare cases.

yakra added a commit to yakra/DataProcessing that referenced this pull request Nov 2, 2021
@yakra yakra mentioned this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code organization data quality datacheck enhancement LABEL_SELFREF This is a temporary tag, as several open issues concern this specific datacheck. speed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LABEL_SELFREF on letter-suffixed routes LABEL_SELFREF efficiency
2 participants