Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for some simple descriptor types #3

Merged
merged 4 commits into from
Oct 2, 2020
Merged

Conversation

MarijnS95
Copy link
Member

Include simple test cases to validate common HLSL types.

This adds an (optional) dependency on hassle-rs and dxcompiler.dll to compile the test shader; by default (cargo test) it is unused, and will only be (re)compiled with cargo test --features test-compile-shaders. Unfortunately cargo doesn't support optional dependencies in dev-dependencies, nor is there a dev-features section.

@Jasper-Bekkers
Copy link
Member

Jasper-Bekkers commented Aug 21, 2020

I think we shouldn't have hassle as a dependency here, and instead just have raw strings with spirv that we disassemble with rspirv. That way we can keep the lib fully platform agnostic and just have CI on linux too (instead of adding windows).

@MarijnS95
Copy link
Member Author

@Jasper-Bekkers There currently is "no dependency" on Hassle/dxcompiler unless --features test-compile-shaders is passed, which is not used on the CI. Seemed like a nice middle-ground to update the shader easily.

Adding Windows was merely to validate the entire thing compiles on both platforms, but this is pretty much implied as there are (obviously) no platform-specific pieces of code.

@Jasper-Bekkers Jasper-Bekkers marked this pull request as ready for review October 2, 2020 11:38
@Jasper-Bekkers Jasper-Bekkers merged commit 594a7d7 into master Oct 2, 2020
@MarijnS95 MarijnS95 deleted the tests branch October 2, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants