Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpm unmerge #53

Merged
merged 4 commits into from Aug 1, 2020
Merged

Tpm unmerge #53

merged 4 commits into from Aug 1, 2020

Conversation

krystian-hebel
Copy link
Collaborator

No description provided.

@krystian-hebel
Copy link
Collaborator Author

krystian-hebel commented Jul 23, 2020

Of course I'll change the submodule repo URL, this is temporarily set to our fork just to test if Travis can deal with submodules. This requires TrenchBoot/tpmlib#20 to work.

@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2020

This pull request introduces 1 alert when merging 745ffe1 into d8f0fc0 - view on LGTM.com

new alerts:

  • 1 for Implicit function declaration

.gitmodules Outdated Show resolved Hide resolved
include/types.h Outdated Show resolved Hide resolved
This makes it compatible with Linux's API. All usages were also fixed,
except for pci_conf1_write() - it was using the new order previously,
which was an error.

Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
This fixes implicit function declaration for hosted builds due to memset()
being used in the TPM code.

Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Copy link
Collaborator

@rossphilipson rossphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Ross Philipson ross.philipson@oracle.com

@dpsmith dpsmith merged commit d55c65b into TrenchBoot:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants