Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1656: Don't start a face drag in brush tool if there is no face under the mouse. #1658

Merged
merged 1 commit into from Jan 17, 2017
Merged

#1656: Don't start a face drag in brush tool if there is no face under the mouse. #1658

merged 1 commit into from Jan 17, 2017

Conversation

kduske
Copy link
Collaborator

@kduske kduske commented Jan 16, 2017

Closes #1656.

@kduske kduske self-assigned this Jan 16, 2017
@kduske kduske requested a review from ericwa January 16, 2017 22:30
ericwa
ericwa approved these changes Jan 17, 2017
View reviewed changes
Copy link
Collaborator

@ericwa ericwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this fixes the crash when holding shift and dragging outside of the brush tool current polygon

@kduske kduske merged commit 8ce4a2a into release/v2.0.0 Jan 17, 2017
@kduske kduske deleted the feature/1656 branch November 6, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwa ericwa ericwa approved these changes

Assignees

@kduske kduske

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kduske @ericwa