feat: 170 use gltf exporter #290
Conversation
|
|
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @andretchen0 could you check if all the conversations where solved please? |
@alvarosabu : Will do. |
|
Hey @JaimeTorrealba It looks like these change requests are still pending:
😉 |
|
@andretchen0 sorry I haven't paid attention to this notification. Sorry. Done :). And thanks, as you may guest I'm not good with the English grammar |
No worries man. You're doing a lot better than me in my second language, lol. |
|
Awesome, @JaimeTorrealba merge latest main to resolve conflicts and we are ready to merge this PR |
|
@alvarosabu done :D |
| @@ -0,0 +1,63 @@ | |||
| <script setup lang="ts"> | |||
| import { TresCanvas, useRenderLoop } from '@tresjs/core' | |||
| import { CameraControls, useTweakPane, useGLTFExporter } from '@tresjs/cientos' | |||
There was a problem hiding this comment.
This errors out for me.
I believe it's because latest Cientos no longer exports useTweakPane.
| const donutGeometry = new TorusGeometry(1, 0.5, 16, 32) | ||
| const boxRef = shallowRef() | ||
|
|
||
| const { pane } = useTweakPane() |
There was a problem hiding this comment.
Since there's no useTweakPane this should probably be converted to Leches.
There was a problem hiding this comment.
You're complete right, thanks for pointing Andre. It's already fix
|
@alvarosabu please your approval here is necessary :) |
|
@alvarosabu sorry for tag you again, I would like to merge this one :) |
closes #170