-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 170 use gltf exporter #290
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry chamo, can't pass this with an any
, isn't the type TresObject3D
helpful here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Works as expected. For me, there are just a few points to look over.
Hey @andretchen0 could you check if all the conversations where solved please? |
@alvarosabu : Will do. |
Hey @JaimeTorrealba It looks like these change requests are still pending:
😉 |
@andretchen0 sorry I haven't paid attention to this notification. Sorry. Done :). And thanks, as you may guest I'm not good with the English grammar |
No worries man. You're doing a lot better than me in my second language, lol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Awesome, @JaimeTorrealba merge latest main to resolve conflicts and we are ready to merge this PR |
@alvarosabu done :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since merging in main
, the playground example is broken. useTweakPane
will need to be converted to Leches.
@@ -0,0 +1,63 @@ | |||
<script setup lang="ts"> | |||
import { TresCanvas, useRenderLoop } from '@tresjs/core' | |||
import { CameraControls, useTweakPane, useGLTFExporter } from '@tresjs/cientos' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This errors out for me.
I believe it's because latest Cientos no longer exports useTweakPane
.
const donutGeometry = new TorusGeometry(1, 0.5, 16, 32) | ||
const boxRef = shallowRef() | ||
|
||
const { pane } = useTweakPane() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there's no useTweakPane
this should probably be converted to Leches
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're complete right, thanks for pointing Andre. It's already fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. Works as advertised! Just one small typo to fix.
I'll approve the PR either way, but as an optional addition, could we also show how to download the whole Tres scene? No problem if you'd rather keep it simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for adding the scene example.
@alvarosabu please your approval here is necessary :) |
@alvarosabu sorry for tag you again, I would like to merge this one :) |
closes #170