Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 557 cookbook #558

Merged
merged 16 commits into from
Mar 5, 2024
Merged

docs: 557 cookbook #558

merged 16 commits into from
Mar 5, 2024

Conversation

alvarosabu
Copy link
Member

@alvarosabu alvarosabu commented Feb 21, 2024

Closes #557

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit ed235e4
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/65e60e5589c9fa0008501a39
😎 Deploy Preview https://deploy-preview-558--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JaimeTorrealba JaimeTorrealba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it just a couple of suggestions

The separator should be below or the title go on top, seems like the group belong to the aku aku
image

  1. The images should be clickable, please. jejeje

  2. This is a question I don't see the changes of cookbook for examples in the old blog entries, is this necessary?

  3. Lastly another a suggestion, maybe put a little info block tell users that the spicy is difficulty :D

I love the concept and the work, any others ideas for this section in the future?

@alvarosabu alvarosabu self-assigned this Mar 4, 2024
@alvarosabu alvarosabu added the docs Improvements or additions to documentation label Mar 4, 2024
@damienmontastier
Copy link

Hey @alvarosabu, looking at the deploy version and the Cookbook examples, it looks like there's a problem with the Cientos version, which is causing problems with the orbit control drag smooth, which isn't working. I've seen the same problem on the Lab repo.

@alvarosabu
Copy link
Member Author

Hey @damienmontastier ! The issue was due to the merge of a broken version of the German translations #544 but @Tinoooo fixed it

@alvarosabu
Copy link
Member Author

@Tinoooo @DennisSmuda could you please check the german translations for the cookbook?

@DennisSmuda
Copy link
Contributor

@Tinoooo @DennisSmuda could you please check the german translations for the cookbook?

I did some updates - very nice work ✅

@alvarosabu alvarosabu merged commit d5a0b19 into main Mar 5, 2024
7 checks passed
@alvarosabu alvarosabu deleted the docs/557-cookbook branch March 5, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookbook 🧑‍🍳
4 participants