Skip to content
This repository has been archived by the owner on Jul 2, 2018. It is now read-only.

userdomain: strengthen user terminals access #96

Merged
merged 1 commit into from
Mar 1, 2017
Merged

userdomain: strengthen user terminals access #96

merged 1 commit into from
Mar 1, 2017

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Feb 17, 2017

prohibit open by using inherited perms, introduced by Russell Coker

Copy link
Contributor

@pebenito pebenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there needs to be new interfaces for the inherited access, as there may be legitimate users of an interface that has open too.

@cgzones
Copy link
Contributor Author

cgzones commented Feb 18, 2017

For 100% backward compatibility: yes a new interface would be needed.
But properly most of the callers do not need the open permission, and converting and testing all of them would be tedious.
One exception I found is screen/tmux (screen_domain).

@pebenito
Copy link
Contributor

It should be easy to fix the usage. Use sed :)

@cgzones
Copy link
Contributor Author

cgzones commented Feb 18, 2017

But when simply replacing the calls, what's the difference by keeping the name and introducing a new interface userdom_open_user_terminals for respective domains?

@pebenito
Copy link
Contributor

Nonetheless the compatibility needs to be preserved.

@cgzones
Copy link
Contributor Author

cgzones commented Feb 21, 2017

is the new approach better?

@pebenito
Copy link
Contributor

I think the interface changes are fine, though I think the TODOs aren't necessary.

@pebenito
Copy link
Contributor

Please drop the TODOs and I'll merge.

@cgzones
Copy link
Contributor Author

cgzones commented Feb 27, 2017

rebased, btw. can you document the usage of analysis annotation like <infoflow type="both" weight="10"/> or <rolecap/>

@pebenito pebenito merged commit 1f1e247 into TresysTechnology:master Mar 1, 2017
@cgzones cgzones deleted the userdom_terminals_permit_open branch March 1, 2017 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants