Use custom parser instead of postcss-safe-parser #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively reverts 20e5242, which broke an existing test case. 😓 It also changes the parser used by the postcss plugins, which fixes a new test case and I think the case that 20e5242 was intended to solve (must confirm!).
Explanation
When
postcss-safe-parser
sees code likeit sees that
PLACEHOLDER_PATTERN;
isn't valid CSS syntax, so it treats it as whitespace. This is a problem for us becausepostcss-nested
makes no effort to keep whitespace in the same block (or any block, for that matter), yieldingThe fix here is to use a modified version of
postcss-safe-parser
that treats these "unknown words" as declarations instead, yielding