Add support for subpackage-specific compiler flags (#442) #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of this I also: * Refactored the code some to be more maintainable * Added documentation for subpackages-specific compiler flags * Added a new doc subsetion to explain how to print out compiler options for each package * Moved the doc subsection for adding arbitrary link options after all of the subsections about manipulating compiler flags/options
bartlettroscoe
force-pushed
the
442-subpackage-lang-flags
branch
from
c6fbcb3
to
8ddc37c
Compare
bartlettroscoe
changed the title
This was referenced Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements, tests, and documents support for appending compiler options to specific subpackages (see #442 and trilinos/Trilinos#10111).
This includes the addition of very strong tests including system-level tests that pins down all of the compiler options and ensure they are passed to the compiler as they should be. (It took a long time to write these tests and make them portable.)
The updated documentation can be viewed at: