WILL NOT MERGE: Fix and reapply: TriBITS: Pull in partial refactoring to modern CMake targets (TriBITSPub/TriBITS#299) (#9894, #9972, #9973) #9978

bartlettroscoe · 2021-11-29T20:44:34Z

This PR reverts the revert commit from PR #9977 and therefore reapplies the merge of PR #9894.

This PR branch addresses the issues reported in #9972 and #9973 and listed in TriBITSPub/TriBITS#433 and offers the chance for developers to try out these changes in their own configurations so we can get this fixed.

In addition to reverting the revert commit from PR #9977, this also pulls in the additional TriBITS PRs (listed most recent to least recent):

Better document <Project>_IMPORTED_NO_SYSTEM and workarounds (#443) TriBITSPub/TriBITS#459
Add support for <Project>_IMPORTED_NO_SYSTEM and related (#443) TriBITSPub/TriBITS#456
Add support for subpackage-specific compiler flags (#442) TriBITSPub/TriBITS#453
Fixed spelling mistakes TriBITSPub/TriBITS#452
Some more fixups for snapshot-dir.py (#160) TriBITSPub/TriBITS#450
Some fixups to snapshot-dir.py (#160, SPAR-614) TriBITSPub/TriBITS#449
Adjust git checkout -B output regex for updated git version TriBITSPub/TriBITS#447
Make install DESTINATION relative for stuff TriBITSPub/TriBITS#446
Improve TribitsExampleProject and TribitsExampleApp readme TriBITSPub/TriBITS#445
Indicated the role of target_link_libraries in 8.7 section TriBITSPub/TriBITS#444
TribitsExampleProject readme fix TriBITSPub/TriBITS#441
Give TribitsSimpleExampleApp the utils program to match TribitsOldSimpleExampleApp (#299) TriBITSPub/TriBITS#440
Add back deprecated non-namespaced library targets (#299, #433) TriBITSPub/TriBITS#439
Add beginning '-- ' to NOTE for general link arguments (#299, #433) TriBITSPub/TriBITS#438
Fix issues with <tplName>Config.cmake generation for TriBITGS TPLs from trilinos/Trilinos#9894 (#433) TriBITSPub/TriBITS#436
Address <Package>Config.cmake file with includes to non-enabled subpackages (#433, #299) TriBITSPub/TriBITS#435
Fix issue on native Windows and partial test suite port (#299) TriBITSPub/TriBITS#432

This PR also addresses issues with several application codes.

NOTE: This PR breaks backward compatibility of the usage of <Package>Config.cmake files from Trilinos. (See release note for Trilinos 14.0 here)

Tasks:

Reproduce and resolve issues with Albany (Albany configure errors due to TriBITS update on 11/25/2021 #9972 and internal tribitsrefactoring#1)
Bring back DEPRECATED non-namespace IMPORTED targets (see Move to modern CMake target-based propagation of build information TriBITSPub/TriBITS#299 (comment)).
Reproduce and resolve issues with Nalu (Nalu configure issues due to Kokkos or SEACAS? #9973 and internal tribitsrefactoring#2)
Reproduce and resolve issues with SPARC (SPAR-1074 and internal tribitsrefactoring#3)
Add documentation on break in backward compatibility with -I to -isystem for Trilinos includes.
Get green-light to merge this (i.e. once Trilinos 13.4 branch is created, see Trilinos 13.4 release status #10191)
Get this PR approved to be merged and pass PR testing
Merge this PR

How was this tested?

Testing against ATDM Trilinos builds using -mkl

To verify the problem with the -mkl option is resolved with the ATDM Trilinos builds described below with this PR branch, I ran the ATDM Trilinos 'sems-rhel7' builds on the CEE machine 'cee-build015' and posted to CDash at:

https://testing-dev.sandia.gov/cdash/index.php?project=Trilinos&date=2021-12-15&filtercount=4&showfilters=1&filtercombine=and&field1=site&compare1=63&value1=cee-build015&field2=buildname&compare2=62&value2=Trilinos-atdm-sems-rhel7-cuda-10.1-Volta70-complex-shared-release-debug-exp&field3=buildstarttime&compare3=83&value3=2021-12-15T18%3A31%3A11%20UTC&field4=buildstarttime&compare4=84&value4=2021-12-16T02%3A15%3A20%20UTC

This showed no new failures. See details below.

Detailed ATDM Trilinos 'sems-rhel7' build and test results (click to expend)

.

Running ATDM Trilinos 'sems-rhel7' builds on 'cee-build015':

$ cd cee-build015

$ /scratch/rabartl/Trilinos.base/BUILDS/ATDM/SEMS-RHEL7/CTEST_S/

$ rm -r Trilinos-atdm-sems-rhel7-*

$ env ./ctest-s-local-test-driver.sh all

That is submitting to CDash (excluding the CUDA build since that machine does not have a GPU):

https://testing-dev.sandia.gov/cdash/index.php?project=Trilinos&date=2021-12-15&filtercount=4&showfilters=1&filtercombine=and&field1=site&compare1=63&value1=cee-build015&field2=buildname&compare2=62&value2=Trilinos-atdm-sems-rhel7-cuda-10.1-Volta70-complex-shared-release-debug-exp&field3=buildstarttime&compare3=83&value3=2021-12-15T18%3A31%3A11%20UTC&field4=buildstarttime&compare4=84&value4=2021-12-16T02%3A15%3A20%20UTC

which gives:

Site	Build Name	Conf Warn	Conf Test Time	Build Error	Build Warn	Build Test Time	Start Test Time
cee-build015	Trilinos-atdm-sems-rhel7-intel-18.0.5-openmp-shared-release-debug-exp	1	2m 35s	0	15	3h 55m 45s	0
cee-build015	Trilinos-atdm-sems-rhel7-intel-18.0.5-openmp-shared-debug-exp	1	2m 18s	0	15	1h 42m 27s	0
cee-build015	Trilinos-atdm-sems-rhel7-intel-18.0.5-openmp-complex-shared-release-debug-exp	0	1m 5s	0	13	1h 47m 27s	0
cee-build015	Trilinos-atdm-sems-rhel7-gnu-7.2.0-openmp-complex-shared-release-debug-exp	0	52s	0	17	24m 31s	0
cee-build015	Trilinos-atdm-sems-rhel7-clang-7.0.1-openmp-shared-release-debug-exp	1	2m 15s	4	39	1h 9m 14s	1

(NOTE: The build errors for the build Trilinos-atdm-sems-rhel7-clang-7.0.1-openmp-shared-release-debug for the package Krino are also see in the reference Trilinos builds on 2021-12-12 and are therefore not caused by the TriBITS changes.)

The configure output for the Intel 18 build showin here which uses -mkl shows:

Processing enabled TPL: BLAS (enabled explicitly, disable with -DTPL_ENABLE_BLAS=OFF)
-- BLAS_LIBRARY_NAMES='blas blas_win32'
-- TPL_BLAS_LIBRARIES='-mkl'
NOTE: Moving the general link argument '-mkl' in TPL_BLAS_LIBRARIES forward on the link line which may change the link and break the link!
Processing enabled TPL: LAPACK (enabled explicitly, disable with -DTPL_ENABLE_LAPACK=OFF)
-- LAPACK_LIBRARY_NAMES='lapack lapack_win32'
-- TPL_LAPACK_LIBRARIES='-mkl'
NOTE: Moving the general link argument '-mkl' in TPL_LAPACK_LIBRARIES forward on the link line which may change the link and break the link!

I also examined the generated generated files BLASConfig.cmake and LAPACKConfig.cmake show which show:

Trilinos-atdm-sems-rhel7-intel-18.0.5-openmp-shared-release-debug/SRC_AND_BUILD/BUILD/external_packages/BLAS/BLASConfig.cmake

# Package config file for external package/TPL 'BLAS'
#
# Generated by CMake, do not edit!

include_guard()

add_library(BLAS::all_libs INTERFACE IMPORTED GLOBAL)
target_link_options(BLAS::all_libs
  INTERFACE "-mkl"
  )

Trilinos-atdm-sems-rhel7-intel-18.0.5-openmp-shared-release-debug/SRC_AND_BUILD/BUILD/external_packages/LAPACK/LAPACKConfig.cmake

# Package config file for external package/TPL 'LAPACK'
#
# Generated by CMake, do not edit!

include_guard()

add_library(LAPACK::all_libs INTERFACE IMPORTED GLOBAL)
target_link_options(LAPACK::all_libs
  INTERFACE "-mkl"
  )

Those look correct.

But note that the targets BLAS::all_libs and LAPACK:all_libs are not used to actually link so this is not a full validation of this approach. However, I manually tested moving -mkl option to the beginning of the link line and it still worked (but if you took, -mkl off the link lines, the link failed).

Therefore, I am pretty confident that this should work.

Other tests?*

ndellingwood · 2021-11-30T00:35:10Z

@bartlettroscoe prior to the changes of #9894 I've had to configure my Trilinos builds (gcc compilers) that use locally installed BLAS and LAPACK (not found on system PATH) by specifying the libraries, as well as the gfortran and math libs to prevent linker errors, using sample configure commands like this (OpenBlas my local install referenced here):

...
  -D TPL_ENABLE_BLAS:STRING=ON \
   -D TPL_BLAS_LIBRARIES:PATH="${OPENBLAS_PATH}/lib/libopenblas.a;gfortran;gomp;m" \
  -D TPL_ENABLE_LAPACK:STRING=ON \
   -D TPL_LAPACK_LIBRARIES:PATH="${OPENBLAS_PATH}/lib/libopenblas.a;gfortran;gomp;m" \
...

After the #9894 changes my builds would fail at configuration with messages like:

CMake Error at cmake/tribits/core/utils/MessageWrapper.cmake:75 (message):
  ERROR: Can't handle argument 'm' in list TPL_BLAS_LIBRARIES
...
CMake Error at cmake/tribits/core/utils/MessageWrapper.cmake:75 (message):
  ERROR: Can't handle argument 'gomp' in list TPL_BLAS_LIBRARIES
...

Once this PR moves out of WIP, should TPL configure commands like I posted resume working? If not, is a different delimiter from the semi-colon expected, or will the process change for specifying additional libraries that need to be explicitly linked with TPLs?

bartlettroscoe · 2021-11-30T16:33:04Z

  -D TPL_ENABLE_BLAS:STRING=ON \
  -D TPL_BLAS_LIBRARIES:PATH="${OPENBLAS_PATH}/lib/libopenblas.a;gfortran;gomp;m" \

@ndellingwood, I was not aware that you could just pass in a library name <libname> instead of -l<libname> to target_link_libraries(). But now I see that is a valid documented usage at:

https://cmake.org/cmake/help/v3.17/command/target_link_libraries.html#overview

I will update the logic in the new TriBITS code to allow a raw string name <libname> to assume it is a a library name and treat it the same as -l<libname>. That should resolve these use cases.

Thanks for reporting this!

bartlettroscoe · 2021-11-30T17:03:44Z

FYI: Another problem with the updated TriBITS in PR #9894 is not allowing options like -mkl like are used in a lot of the ATDM Trilinos builds as shown at:

https://testing.sandia.gov/cdash/index.php?project=Trilinos&date=2021-11-27&filtercount=3&showfilters=1&filtercombine=and&field1=groupname&compare1=62&value1=Experimental&field2=buildname&compare2=65&value2=Trilinos-atdm-&field3=configureerrors&compare3=43&value3=0

which are:

Site	Build Name	Revision	C Err	C Warn	Start Time	Labels
sems-rhel7	Trilinos-atdm-sems-rhel7-intel-18.0.5-openmp-shared-release-debug	590342	1	1	Nov 27, 2021 - 03:41 MST	(29 labels)
sems-rhel7	Trilinos-atdm-sems-rhel7-intel-18.0.5-openmp-complex-shared-release-debug	590342	1	0	Nov 27, 2021 - 03:41 MST	(15 labels)
skybridge	Trilinos-atdm-tlcc2-intel-opt-openmp	590342	1	1	Nov 27, 2021 - 04:03 MST	(29 labels)
eclipse	Trilinos-atdm-cts1-intel-19.0.4_openmpi-4.0.3_openmp_static_opt	590342	1	0	Nov 27, 2021 - 02:09 MST	(32 labels)
eclipse	Trilinos-atdm-cts1empire-intel-18.0.2_openmpi-4.0.1_openmp_static_opt	590342	1	0	Nov 27, 2021 - 02:05 MST	(32 labels)
mutrino	Trilinos-atdm-ats1-knl_intel-19.0.4_mpich-7.7.15_openmp_static_opt	590342	1	0	Nov 26, 2021 - 23:37 MST	(32 labels)
chama	Trilinos-atdm-tlcc2-intel-debug-openmp	590342	1	1	Nov 27, 2021 - 04:10 MST	(29 labels)
sems-rhel7	Trilinos-atdm-sems-rhel7-intel-18.0.5-openmp-shared-debug	590342	1	1	Nov 27, 2021 - 03:33 MST	(29 labels)
eclipse	Trilinos-atdm-cts1empire-intel-18.0.2_openmpi-4.0.1_openmp_static_dbg	590342	1	0	Nov 27, 2021 - 02:09 MST	(32 labels)
eclipse	Trilinos-atdm-cts1-intel-19.0.4_openmpi-4.0.3_openmp_static_dbg	590342	1	0	Nov 27, 2021 - 02:08 MST	(32 labels)
mutrino	Trilinos-atdm-ats1-hsw_intel-19.0.4_mpich-7.7.15_openmp_static_dbg	590342	1	0	Nov 27, 2021 - 00:07 MST	(32 labels)
mutrino	Trilinos-atdm-ats1-knl_intel-19.0.4_mpich-7.7.15_openmp_static_dbg	590342	1	0	Nov 26, 2021 - 23:57 MST	(32 labels)
mutrino	Trilinos-atdm-ats1-hsw_intel-19.0.4_mpich-7.7.15_openmp_static_opt	590342	1	0	Nov 26, 2021 - 23:47 MST	(32 labels)

We see errors like here showing:

-- TPL_BLAS_LIBRARIES='-mkl'
CMake Error at /gpfs1/jenkins/chama-slave/workspace/Trilinos-atdm-tlcc2-intel-debug-openmp/Trilinos/cmake/tribits/core/utils/MessageWrapper.cmake:75 (message):
  ERROR: Can't handle argument '-mkl' in list TPL_BLAS_LIBRARIES
Call Stack (most recent call first):
  /gpfs1/jenkins/chama-slave/workspace/Trilinos-atdm-tlcc2-intel-debug-openmp/Trilinos/cmake/tribits/core/package_arch/TribitsExternalPackageWriteConfigFile.cmake:293 (message_wrapper)
  /gpfs1/jenkins/chama-slave/workspace/Trilinos-atdm-tlcc2-intel-debug-openmp/Trilinos/cmake/tribits/core/package_arch/TribitsExternalPackageWriteConfigFile.cmake:208 (tribits_external_package_process_libraries_list)
  /gpfs1/jenkins/chama-slave/workspace/Trilinos-atdm-tlcc2-intel-debug-openmp/Trilinos/cmake/tribits/core/package_arch/TribitsExternalPackageWriteConfigFile.cmake:67 (tribits_external_package_write_config_file_str)
  /gpfs1/jenkins/chama-slave/workspace/Trilinos-atdm-tlcc2-intel-debug-openmp/Trilinos/cmake/tribits/core/package_arch/TribitsTplFindIncludeDirsAndLibraries.cmake:684 (tribits_external_package_write_config_file)
  /gpfs1/jenkins/chama-slave/workspace/Trilinos-atdm-tlcc2-intel-debug-openmp/Trilinos/cmake/tribits/common_tpls/FindTPLBLAS.cmake:79 (TRIBITS_TPL_FIND_INCLUDE_DIRS_AND_LIBRARIES)
  /gpfs1/jenkins/chama-slave/workspace/Trilinos-atdm-tlcc2-intel-debug-openmp/Trilinos/cmake/tribits/core/package_arch/TribitsProcessEnabledTpl.cmake:108 (include)
  /gpfs1/jenkins/chama-slave/workspace/Trilinos-atdm-tlcc2-intel-debug-openmp/Trilinos/cmake/tribits/core/package_arch/TribitsGlobalMacros.cmake:1572 (tribits_process_enabled_tpl)
  /gpfs1/jenkins/chama-slave/workspace/Trilinos-atdm-tlcc2-intel-debug-openmp/Trilinos/cmake/tribits/core/package_arch/TribitsProjectImpl.cmake:196 (tribits_process_enabled_tpls)
  /gpfs1/jenkins/chama-slave/workspace/Trilinos-atdm-tlcc2-intel-debug-openmp/Trilinos/cmake/tribits/core/package_arch/TribitsProject.cmake:93 (tribits_project_impl)
  CMakeLists.txt:109 (TRIBITS_PROJECT)

I think to address this, we need to update the TriBITS logic to allow the handling of compiler options like -mkl. I need to check and see if the location of the -mkl option matters or not (but it should not because the MKL libraries should not depend on anything you pass into the link line). If the order does matter, then I think we are in trouble. If the order does not matter, then we can just handle it as a general linker flag. I will just experiment and see if this is the case or not but my guess is that handling this as a general compiler flag that gets moved forward on the link line should be just fine.

bartlettroscoe · 2021-12-01T22:17:05Z

Note that in both #9972 and #9973, the find_package(Trilinos) command is returning FALSE for Trilinos_FOUND. It looks like these Apps may not be adding REQUIRED to their calls of find_package(Trilinos COMPONENTS ...)?

I will try to reproduce and see what is going on.

bartlettroscoe · 2021-12-02T19:16:06Z

FYI: I found the problem with #9972. The issue is that Trilinos/TriBITS generated the STKConfig.cmake file with no includes of upstream packages or subpackages. Instead, it contains the text:

## The TPLs enabled for this project
set(STK_TPL_LIST "")

# Include configuration of dependent packages

# Include configuration of dependent external packages/TPls

# Import STK targets
include("${CMAKE_CURRENT_LIST_DIR}/STKTargets.cmake")

I tried to reproduce with a full SEMS configuration of Trilinos and I could not reproduce. But this should be easy to debug (and hopefully produce a TriBITS test to catch without a lot of work).

alanw0 · 2021-12-02T19:21:42Z

@bartlettroscoe Let me know if that means that anything needs to be fixed or improved in stk's cmake stuff. Thanks!

bartlettroscoe · 2021-12-02T23:23:40Z

@bartlettroscoe Let me know if that means that anything needs to be fixed or improved in stk's cmake stuff. Thanks!

@alanw0, it is definingly not a STK CMake bug, it is a TriBITS bug related to work for TriBITSPub/TriBITS#299. I have reproduced the problem with a native TriBITS test and will fix this. (I was missing a test case.)

…Trilinos/tribits-299-modern-cmake-targets-1"" This reverts commit fd27a20. This gets us back to the state of the 'develop' branch after the PR trilinos#9894 that merged the branch 'tribits-299-modern-cmake-targets-1' was merged (as well as other PRs in the days after that). Now I can try to reproduce the errors in issues trilinos#9972 and trilinos#9973.

Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git' At commit: commit 35d82aaa31fe81ca30a619320bb71fe481e9d4c7 Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Tue Dec 14 15:48:02 2021 -0700 Summary: Interpret a raw identifer in TPL_<tplName>_LIBRARIES as a lib name (trilinos#299, trilinos#433)

…targets-1-again (TriBITSPub/TriBITS#433) Should address all of the issues with the merge of PR trilinos#9894 listed out in TriBITSPub/TriBITS#433 (which is part of TriBITSPub/TriBITS#299). This should resolve the failures reported in trilinos#9972 and trilinos#9973.

trilinos-autotester · 2021-12-15T17:26:24Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2021-12-15T17:26:58Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver

Build Num: 273
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver_uvm_off

Build Num: 209
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)

Pull Request Author: bartlettroscoe

trilinos-autotester · 2021-12-15T17:28:32Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver

Build Num: 273
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver_uvm_off

Build Num: 209
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

Build Num: 6225
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

Build Num: 3753
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

Build Num: 4273
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 11387
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

Build Num: 4185
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: python-3

Build Num: 820
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)

Pull Request Author: bartlettroscoe

trilinos-autotester · 2021-12-15T21:49:58Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver

Build Num: 273
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver_uvm_off

Build Num: 209
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

Build Num: 6225
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

Build Num: 3753
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

Build Num: 4273
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 11387
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

Build Num: 4185
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

Build Information

Test Name: python-3

Build Num: 820
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	type: bug;TriBITS
PULLREQUESTNUM	9978
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	tribits-299-modern-cmake-targets-1-again
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`963854c`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`267042c`

CDash Test Results for PR# 9978.

trilinos-autotester · 2021-12-15T21:50:15Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

trilinos-autotester · 2021-12-15T21:50:21Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

spdomin · 2021-12-16T18:08:42Z

We are still trying to understand this latest change and why we are seeing diffs when running Nalu against this PR.

Below is some recent activity:

Good:

12/16/2021 NaluRtest
100% tests passed, 0 tests failed out of 75
NaluCFD/Nalu SHA1: 11940e2700d4b94d46b75efe572f2579148c098f
Trilinos/develop SHA1: 9732a48

Bad:

commit 11940e2700d4b94d46b75efe572f2579148c098f (HEAD -> master, origin/master, origin/HEAD)
commit 963854c (HEAD -> tribits-299-modern-cmake-targets-1-again, bartlettroscoe/tribits-299-modern-cmake-targets-1-again)

1/75 Test #75: waleElemXflowMixFrac3.5m ...............***Failed 285.16 sec
Start 33: hoHelium
2/75 Test #73: oversetHybrid ..........................***Failed 495.67 sec
Start 32: heliumPlume

However, running the current version of all codes results in:

Good:

100% tests passed, 0 tests failed out of 75
NaluCFD/Nalu SHA1: 11940e2700d4b94d46b75efe572f2579148c098f
Trilinos/develop SHA1: 93bbee4

trilinos-autotester · 2022-03-10T00:14:17Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2022-03-11T00:24:38Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2022-03-12T00:24:37Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2022-03-13T00:24:37Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2022-03-14T00:24:37Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2022-03-15T00:26:44Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

trilinos-autotester · 2022-03-16T00:28:25Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

trilinos-autotester · 2022-03-17T01:36:00Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

trilinos-autotester · 2022-03-18T02:49:36Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

trilinos-autotester · 2022-03-19T13:04:36Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

trilinos-autotester · 2022-03-20T13:04:36Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

bartlettroscoe · 2022-03-20T17:46:58Z

It does not look like this will be merged soon and the PR testing passing result as gone stale (and we are not getting daily reminders of this fact). Therefore, I am putting the label AT: WIP back on to stop these daily reminders.

Once we get the green-light to merge this (i.e. after the Trilinos 13.4 release branch is created), then I will remove AT: WIP, add AT: RETEST and get this tested, approved, and merged .

keitat · 2022-03-25T00:37:24Z

FYI: I am trying this at:
(1) kahuna (Cluster system at CA V100 GPUs, CUDA 11.0.1 CMake 3.19.1)
(2) crusher (ORNL, Exascale TestBed, AMD CPU and GPUs, CMake 3.21.1)

bartlettroscoe · 2022-03-25T00:43:02Z

FYI: I am trying this at:

@keitat, if you could try this with Spack with the xSDK, that would be good.

bartlettroscoe · 2022-05-16T16:53:20Z

CC: @keitat

@jwillenbring and @ccober6,

Does the below announcement mean that I can merge this Trilinos PR and other backward incompatible TriBITS changes to Trilinos 'develop' starting Thursday, May 19?

From: Willenbring, James M jmwille@sandia.gov
Sent: Monday, May 16, 2022 9:03 AM
To: trilinos-announce@trilinos.org; trilinos-developers@trilinos.org
Cc: Ober, Curtis C ccober@sandia.gov
Subject: Deprecated code will soon be dropped from Trilinos develop branch

All,

The Trilinos 13.4 release branch was created last week. The Trilinos 13.4 release is anticipated to be finalized in the next couple of weeks. Beginning on May 19th, Trilinos developers will be removing deprecated code from the develop branch in preparation for the Trilinos 14 release, which we currently anticipate will be completed in about 3 months.

If you have questions or concerns, please contact Curt Ober or Jim Willenbring.

Thanks

Jim

bartlettroscoe · 2022-05-17T15:16:30Z

FYI: I think it is pretty clear that given the PRs #10504 and #10533 and all of the changes to TriBITS 'master' that have been made since this PR was last changed or updated that I am going to need to create a new PR with an updated snapshot of TriBITS and cherry-picking the revert revert commit and the release notes changes from this PR. I will do some more Trilinos testing including against some application codes as mentioned above and then do this all over again.

bartlettroscoe · 2022-05-23T17:28:29Z

Okay, we have been given the okay to merge backwards incompatible changes. As I mentioned above, I need to construct a new PR that includes all of the changes in TriBITS (through TriBITSPub/TriBITS#479). I expect to be ready to create that PR, close this PR, and get that merged soon.

From: Trilinos-developers <...> On Behalf Of Willenbring, James M
Sent: Monday, May 23, 2022 12:05 PM
To: trilinos-developers@...
Subject: [EXTERNAL] [Trilinos-developers] PRs can now be submitted and merged to develop that remove previously deprecated code

All,

At this time, you can remove code that you previously deprecated prior to the 13.4 release. While we have a couple small details to tie up with the 13.4 release, the develop branch is now beyond the point of branching for the 13.4 release. In approximately 3 months, we will cut a 14.0 release of Trilinos. At that time, the window for removing deprecated code will close again until after the final minor 14.x release.

Jim

bartlettroscoe · 2022-06-10T21:59:26Z

Closing this PR for the new PR #10614.

bartlettroscoe added type: bug The primary issue is a bug in Trilinos code or tests AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) TriBITS Issues with the TriBITS framework itself, not usage of the TriBITS framework labels Nov 29, 2021

bartlettroscoe self-assigned this Nov 29, 2021

bartlettroscoe mentioned this pull request Nov 30, 2021

Nalu configure issues due to Kokkos or SEACAS? #9973

Closed

bartlettroscoe mentioned this pull request Dec 2, 2021

Albany configure errors due to TriBITS update on 11/25/2021 #9972

Closed

This was referenced Dec 9, 2021

Address issues from TriBITS snapshot into Trilinos from PR trilinos/Trilinos#9894 (#299) TriBITSPub/TriBITS#433

Closed

Address <Package>Config.cmake file with includes to non-enabled subpackages (#433, #299) TriBITSPub/TriBITS#435

Merged

bartlettroscoe added 3 commits December 15, 2021 08:49

bartlettroscoe force-pushed the tribits-299-modern-cmake-targets-1-again branch from dd88fc9 to 963854c Compare December 15, 2021 17:06

bartlettroscoe removed the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Dec 15, 2021

bartlettroscoe requested review from keitat and a team December 16, 2021 16:25

trilinos-autotester added the AT: STALE Added by the PR autotester if too much time has elapsed since the last successful PR test iteration label Mar 15, 2022

bartlettroscoe added AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) and removed AT: STALE Added by the PR autotester if too much time has elapsed since the last successful PR test iteration labels Mar 20, 2022

bartlettroscoe mentioned this pull request May 6, 2022

Apply Trilinos changes to accept updated TriBITS (TriBITSPub/TriBITS#299) #10504

Merged

e10harvey closed this Jun 3, 2022

e10harvey reopened this Jun 3, 2022

bartlettroscoe mentioned this pull request Jun 10, 2022

TriBITS: Switch to modern cmake targets (TriBITSPub/TriBITS#299) #10614

Merged

16 tasks

bartlettroscoe closed this Jun 10, 2022

WILL NOT MERGE: Fix and reapply: TriBITS: Pull in partial refactoring to modern CMake targets (TriBITSPub/TriBITS#299) (#9894, #9972, #9973) #9978

WILL NOT MERGE: Fix and reapply: TriBITS: Pull in partial refactoring to modern CMake targets (TriBITSPub/TriBITS#299) (#9894, #9972, #9973) #9978

Conversation

bartlettroscoe commented Nov 29, 2021 • edited Loading

Tasks:

How was this tested?

Testing against ATDM Trilinos builds using -mkl

ndellingwood commented Nov 30, 2021

bartlettroscoe commented Nov 30, 2021

bartlettroscoe commented Nov 30, 2021 • edited Loading

bartlettroscoe commented Dec 1, 2021

bartlettroscoe commented Dec 2, 2021

alanw0 commented Dec 2, 2021

bartlettroscoe commented Dec 2, 2021

trilinos-autotester commented Dec 15, 2021

trilinos-autotester commented Dec 15, 2021

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver_uvm_off

Jenkins Parameters

Using Repos:

trilinos-autotester commented Dec 15, 2021

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver_uvm_off

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

Jenkins Parameters

Build Information

Test Name: python-3

Jenkins Parameters

Using Repos:

trilinos-autotester commented Dec 15, 2021

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_cuda_weaver_uvm_off

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

Jenkins Parameters

Build Information

Test Name: python-3

Jenkins Parameters

trilinos-autotester commented Dec 15, 2021

trilinos-autotester commented Dec 15, 2021

spdomin commented Dec 16, 2021

trilinos-autotester commented Mar 10, 2022

trilinos-autotester commented Mar 11, 2022

trilinos-autotester commented Mar 12, 2022

bartlettroscoe commented Nov 29, 2021 •

edited

Loading

bartlettroscoe commented Nov 30, 2021 •

edited

Loading