-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitdist: Pass in '-c color.status=always' when --dist-no-color is not added #588
Conversation
@jmgate, not sure if you are still using gitdist or not but I don't know who else to ask to review a PR like this. |
I also updated documentation to mention that the user should also pass in --color=never as well for non-color output.
Calling --color=never to the right commands. These purpose of these commands is to allow for easy archiving of the repo state in files, etc, and not for the shell.
0cb0109
to
549162d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will go ahead and let this merge without outside review.
I haven't used it in years, but I was about to pick it up again because I was just put on a project with dozens upon dozens of repositories. I'll take a quick look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worthwhile to add some smarts at some point to automatically add --color=always/never
for the commands that accept it, so the user doesn't need to double-specify whether they want colors.
Also, do the -c foo=bar
and --color=foo
options require a certain version of git? Probably doesn't matter, but thought it might be worth checking.
@jmgate, thanks for taking a look! |
…ribits-update This pulls in the new TriBITS PRs: * TriBITSPub/TriBITS#583 * TriBITSPub/TriBITS#585 * TriBITSPub/TriBITS#586 * TriBITSPub/TriBITS#587 * TriBITSPub/TriBITS#588 * TriBITSPub/TriBITS#590
…bits This brings in the following TriBITS PRs: * TriBITSPub/TriBITS#591: Allow 100% raw CMake to be used in a TriBITS-compliant package (TriBITSPub/TriBITS#582) * TriBITSPub/TriBITS#588: gitdist: Pass in '-c color.status=always' when --dist-no-color is not added * TriBITSPub/TriBITS#590: Fix: gitdist: dist-repo-status: Display tag or SHA1 instead of 'HEAD' * TriBITSPub/TriBITS#587: gitdist: dist-repo-status: Display tag or SHA1 instead of 'HEAD' * TriBITSPub/TriBITS#586: More cleanup of packaging support (trilinos#11976) This goes back to TriBITS commits from June 2023.
Have
--dist-no-color
add-c color.status=never
before very git repo command and set-c color.status=always
otherwise.