Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #6269, fixes #6270: DiscoveryCommunity and DHTDiscoveryCommunity disregards config setting #6281

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Fixes #6269, fixes #6270: DiscoveryCommunity and DHTDiscoveryCommunity disregards config setting #6281

merged 3 commits into from
Aug 23, 2021

Conversation

kozlovsky
Copy link
Contributor

This PR resolves #6269 and #6270.

It fixes the incorrect initialization of Ipv8Component.

@kozlovsky
Fixes Tribler#6269, fixes Tribler#6270: DiscoveryCommunity and DHTDis…
cb96aba 
…coveryCommunity disregards config setting
@kozlovsky
Copy link
Contributor Author

retest this please

@kozlovsky kozlovsky marked this pull request as draft August 23, 2021 08:08
qstokkink
qstokkink approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the fix itself.

[Side note] We should really have an issue open for test_components.py. The code duplication in this file is getting problematic.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
50.3% 50.3% Duplication

@kozlovsky
Copy link
Contributor Author

@qstokkink I agree about test components. I plan to refactor the code of test_components.py a bit later to reduce verbosity.

@kozlovsky kozlovsky marked this pull request as ready for review August 23, 2021 09:12
@kozlovsky kozlovsky merged commit 9745335 into Tribler:main Aug 23, 2021
@kozlovsky kozlovsky deleted the fix_6269_6270 branch August 23, 2021 09:13
@qstokkink qstokkink mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qstokkink qstokkink qstokkink approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[main] DHTDiscoveryCommunity disregards config setting
2 participants
@kozlovsky @qstokkink