Feature/trblock

[Cupelt]

No description provided.

[wysohn]

Can't wait to see this go live :)

[wysohn]

Looks really good

But I doubt if having TRBlockManager and TRBlock would make sense since they seem to be doing closely related jobs

If the concern is executing public boolean start() only once, we could put that into initialize() directly instead.

If you prefer having multiple layers of abstraction (which is good), consider creating TRBlock as an interface and creating the TRBlockImpl class which implements the TRBlock interface. In this way, we can avoid depending directly on Javalin. Or it doesn't have to be TRBlock but some more generic name like TRBlockWebServiceProvider

[Cupelt]

i got it

[Cupelt]

@wysohn how about like this?

[wysohn]

@wysohn how about like this?

Pretty close, but not quite

Here is how I envisioned:

Before)

After)

So the point is that in 'before' scenario, TRBlockManager, which is part of TriggerReactor, depends on TRBlock, and TRBlock depends on Javalin, and this makes our project strongly depending on the changes of Javalin

Instead, we let TRBlockManager to depend on TRBlockWebService interface, and make an implementation (JavalinWebService), which will depend on Javalin, so TRBlockManager will no longer depend on Javalin, but it's depending on the abstraction (TRBlockWebService)

[Cupelt]

@wysohn how about like this?

Pretty close, but not quite

Here is how I envisioned:

Before)

After)

So the point is that in 'before' scenario, TRBlockManager, which is part of TriggerReactor, depends on TRBlock, and TRBlock depends on Javalin, and this makes our project strongly depending on the changes of Javalin

Instead, we let TRBlockManager to depend on TRBlockWebService interface, and make an implementation (JavalinWebService), which will depend on Javalin, so TRBlockManager will no longer depend on Javalin, but it's depending on the abstraction (TRBlockWebService)

I understood

[Cupelt]

@wysohnI'm not sure if I understood well, but is this what you meant?

[wysohn]

@wysohnI'm not sure if I understood well, but is this what you meant?

Yes exactly!

As a minor point, the interface name can be TRBlockWebService instead of TRBlockWebServiceImpl cause it's an abstraction, not an implementation

If you prefer to add postfix, Ipml, then JavalinWebService could be JavalinWebServiceImpl, but I think JavalinWebService that implements TRBlockWebService sounds good enough