Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional TLS/Authentication for Contact Support Menu #9

Merged

Conversation

dmccoystephenson
Copy link
Member

@dmccoystephenson dmccoystephenson commented Mar 27, 2024

Problem

In the event that an email server does not support TLS or authentication, the Contact Support Menu ceases to function.

Solution

TLS and authentication have been made optional via the introduction of the CSM_TLS_ENABLED and CSM_AUTH_ENABLED environment variables.

Testing

  • Unit tests have been added and verified to be passing.
  • Sending an email through Google's email server has been verified to work with TLS / AUTH enabled.
  • Sending an email to a locally-running mail server has been verified to work with TLS / AUTH disabled.
  • Sending an email through WYDOT's mail server has been verified to work with TLS / AUTH disabled.

Note

It should be noted that if pretty formatting is enabled, WYDOT's email server won't accept & forward the email. Pretty formatting is explicitly disabled in the contact support menu due to this.

@dmccoystephenson dmccoystephenson marked this pull request as ready for review April 16, 2024 13:53
@dmccoystephenson dmccoystephenson marked this pull request as draft April 16, 2024 21:14
@dmccoystephenson dmccoystephenson marked this pull request as ready for review April 18, 2024 14:46
Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one question, otherwise looks good!

@payneBrandon
Copy link

@dmccoystephenson looks like a couple of merge conflicts

@dmccoystephenson dmccoystephenson marked this pull request as draft July 10, 2024 19:46
@dmccoystephenson
Copy link
Member Author

Keeping this as a draft for now until I can re-verify the functionality for this PR

@dmccoystephenson dmccoystephenson marked this pull request as ready for review July 11, 2024 15:19
Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@payneBrandon payneBrandon merged commit e67b850 into dev Jul 29, 2024
6 checks passed
@payneBrandon payneBrandon deleted the feature/optional-tls-and-auth-for-contact-support-menu branch July 29, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants