-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional TLS/Authentication for Contact Support Menu #9
Optional TLS/Authentication for Contact Support Menu #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one question, otherwise looks good!
@dmccoystephenson looks like a couple of merge conflicts |
Keeping this as a draft for now until I can re-verify the functionality for this PR |
… in `contact_support.py`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Problem
In the event that an email server does not support TLS or authentication, the Contact Support Menu ceases to function.
Solution
TLS and authentication have been made optional via the introduction of the CSM_TLS_ENABLED and CSM_AUTH_ENABLED environment variables.
Testing
Note
It should be noted that if pretty formatting is enabled, WYDOT's email server won't accept & forward the email. Pretty formatting is explicitly disabled in the contact support menu due to this.