Skip to content

Commit

Permalink
DB/Misc: use correct nextquestid for quests 936,3784,3762 Closes #3820.…
Browse files Browse the repository at this point in the history 
… fix blood presence to NOT proc on positive spells (causes issues with healing spells making you heal) Closes #6009. fix dk t10 4peice bonus Closes #6449.
  • Loading branch information
@Star-lion
Star-lion committed May 18, 2012
1 parent d1e0dc3 commit 7e62c34
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions sql/updates/world/2012_05_18_01_world_misc.sql
View file
@@ -0,0 +1,7 @@
DELETE FROM `spell_proc_event` WHERE `entry` = 70656;

UPDATE `quest_template` SET `NextQuestId` = 3761 WHERE `id` IN (936,3784,3762);

DELETE FROM `spell_proc_event` WHERE `entry` = 63611;
INSERT INTO `spell_proc_event` (`entry`,`SchoolMask`,`SpellFamilyName`,`SpellFamilyMask0`,`SpellFamilyMask1`,`SpellFamilyMask2`,`procFlags`,`procEx`,`ppmRate`,`CustomChance`,`Cooldown`) VALUES
(63611,0,0,0,0,0,51154,0,0,0,0);

5 comments on commit 7e62c34

@elecyb
Copy link
Contributor

@elecyb elecyb commented on 7e62c34 May 20, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but why procFlags = 51154 for spell 63611?
51154 match with:

PROC_FLAG_KILL
PROC_FLAG_DONE_SPELL_MELEE_DMG_CLASS
PROC_FLAG_DONE_RANGED_AUTO_ATTACK
PROC_FLAG_TAKEN_RANGED_AUTO_ATTACK
PROC_FLAG_DONE_SPELL_RANGED_DMG_CLASS
PROC_FLAG_TAKEN_SPELL_RANGED_DMG_CLASS
PROC_FLAG_DONE_SPELL_NONE_DMG_CLASS_POS
PROC_FLAG_DONE_SPELL_MAGIC_DMG_CLASS_POS
PROC_FLAG_TAKEN_SPELL_MAGIC_DMG_CLASS_POS

PROC_FLAG_KILL doesn't make sense :S
PROC_FLAG_TAKEN_RANGED_AUTO_ATTACK > now hunter auto shots heal the dk
PROC_FLAG_TAKEN_SPELL_MAGIC_DMG_CLASS_POS > heals received proc the spell also...

I think removing _DMG_CLASS_POS flags is enough

@tibbi
Copy link

@tibbi tibbi commented on 7e62c34 May 21, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh ye, those procflags look kinda random. Ive made it 65876 (including proc on ranged hit, wont hurt being there), not sure if it should heal on aoe dmg and dot ticks too.

@Shauren
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These proc flags are correct, however the sql is wrongly written as its missing 0x for hex interpretation

@tibbi
Copy link

@tibbi tibbi commented on 7e62c34 May 22, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, i havent realised that :D ye, they are correct that way

@Star-lion
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crap i thought i converted from hex to decimal so i wouldnt need the 0x >.> sorry!

Please sign in to comment.