[T10 Deathknight] 4 Set bonus

[ghost]

How to reprduce the bug
Open DK
Get 4 Part of Tier 10 gear
makes all your runes be in CD

What is the expected outpot?
The spell - Item - Death Knight T10 Melee 4P Bonus - "Whenever all your runes are on cooldown, you gain 3% increased damage done with weapons, spells, and abilities for the next 15 sec."
Should have proc of 100%.

What happen instead?
The proc isn't 100% , i can't how much % it is now , i just know it isnt 100%

Related Links:
http://www.wowhead.com/spell=70656
http://www.wowhead.com/itemset=-261

Server info:
Hash : a8a5b5a
Tdb: 335.11.46+

[durrrr]

Confirmed.

[Star-lion]

this is a duplicate but im not entirely sure where the other issue is.

[Vincent-Michael]

#2286 ?

[ghost]

You closed the 1st issue , so i didnt know if it would be ok to respon there , so i opened now one ,
sorry for mess

[plorefice]

Confirmed. I've also noticed this behaviour:

• Make all your runes be in CD -> Spell isn't triggered
• Wait for a rune to finish CD, then use it again immediately -> Spell is triggered with 100% proc chance from what I've seen

I think I've also tracked down the code related in Unit.cpp:

// Item - Death Knight T10 Melee 4P Bonus
if (dummySpell->Id == 70656)
{
    Player* player = ToPlayer();
    if (!player)
        return false;

    for (uint32 i = 0; i < MAX_RUNES; ++i)
        if (player->GetRuneCooldown(i) == 0)
            return false;
}
break;

I've tried to add triggered_spell_id = 70657; after the for loop, but it didn't work (I've been working on the code for just a couple of day, so I should have seen it coming).

[Midnights]

try to add an
else return true;
for the if in the loop

[Vincent-Michael]

try mangos version (works for me fine):

diff --git a/src/server/game/Entities/Unit/Unit.cpp b/src/server/game/Entities/Unit/Unit.cpp
index e038d11..28cc99a 100644
--- a/src/server/game/Entities/Unit/Unit.cpp
+++ b/src/server/game/Entities/Unit/Unit.cpp
@@ -8859,6 +8859,16 @@ bool Unit::HandleProcTriggerSpell(Unit* victim, uint32 damage, AuraEffect* trigg
                     trigger_spell_id = 50475;
                     basepoints0 = CalculatePctN(int32(damage), triggerAmount);
                 }
+                // Item - Death Knight T10 Melee 4P Bonus
+                else if (auraSpellInfo->Id == 70656)
+                {
+                    if (GetTypeId() != TYPEID_PLAYER || getClass() != CLASS_DEATH_KNIGHT)
+                        return false;
+
+                    for (uint32 i = 0; i < MAX_RUNES; ++i)
+                        if (((Player*)this)->GetRuneCooldown(i) == 0)
+                            return false;
+                }
                 break;
             }
             case SPELLFAMILY_ROGUE:

[Star-lion]

ewww ill fix this code up later

[plorefice]

I just tried to apply the fix and the problem persists. You can verify it with a simple spell rotation like:
Icy Touch -> Plague Strike -> Blood Strike -> repeat one more time
You'll have all of your runes in CD but the spell doesn't proc. If you however cast Icy Touch again once it's ready, the spell will actually proc. I don't know if this behaviour is expected, but from what the description reads, I'd say it isn't.

[Vincent-Michael]

@Expecto HandleDummyAuraProc is wrong, it is SPELL_AURA_PROC_TRIGGER_SPELL spell ...

[Star-lion]

uhh how about try

DELETE FROM `spell_proc_event` WHERE `entry` = 70656;

also it shouldnt apply this aura if you already have it right?

[ghost]

if in there is 0 in proc chance what its means?

[TGM]

@Kandera, spell_proc_event patch works just fine, thank you.