Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.3.5a] Battle Shout - overwrites - Blood Pact #12212

Closed
Rushor opened this issue Jun 4, 2014 · 6 comments
Closed

[3.3.5a] Battle Shout - overwrites - Blood Pact #12212

Rushor opened this issue Jun 4, 2014 · 6 comments

Comments

@Rushor
Copy link
Contributor

Rushor commented Jun 4, 2014

core: 8d539ee
db: up to date

Battle Shout (spell=47436) will overrides Blood Pact: (spell=47982) if spell=47982 is apllied.
Usually you should be able to have both buffs.
@untaught
Copy link
Contributor

untaught commented Jun 4, 2014

You mean commanding shout?

@Rushor
Copy link
Contributor Author

Rushor commented Jun 4, 2014

nope the ap buff :D

@ghost
Copy link

ghost commented Jun 4, 2014

Battle Shout increasing attack power of all raid and party members within 30 yards by 548. Lasts 2 min.
Blood Pact Increases party and raid members' health by 1330.
Commanding Shout Increases maximum health of all party and raid members within 30 yards by 2255. Lasts 2 min.

@Rushor
Copy link
Contributor Author

Rushor commented Jun 4, 2014

oh and i will find out some proofs for that soon. :)

@Rushor
Copy link
Contributor Author

Rushor commented Jun 6, 2014

further information: (the origion post can be confusing)
You should be able to have [Battle Shout & Blood Pact] or [Battle Shout & Commanding Shout].
But nevertheless Battle Shout should overwrite the Commanding Shout of the same warrior, if he buffs that himself.

@Aokromes
Copy link
Member

Aokromes commented Jun 6, 2014

#4313

@Aokromes Aokromes closed this as completed Jun 6, 2014
Trisjdc added a commit that referenced this issue Jun 15, 2014
@Trisjdc
DB/SpellGroups: Completely review of WotLK Stack Rules
f278214 
Closes #4313, #1626, #5173, #5822, #12212, #3814, and probably others
Hlkz pushed a commit to Hlkz/Acore that referenced this issue Jun 27, 2014
@Trisjdc
DB/SpellGroups: Completely review of WotLK Stack Rules
03c9f2b 
Closes TrinityCore/TrinityCore#4313, TrinityCore/TrinityCore#1626, TrinityCore/TrinityCore#5173, TrinityCore/TrinityCore#5822, TrinityCore/TrinityCore#12212, TrinityCore/TrinityCore#3814, and probably others

Conflicts:
	src/server/scripts/Northrend/ChamberOfAspects/RubySanctum/boss_halion.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Aokromes @untaught @Rushor