You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
First, honestly, great job.
Second, I've a question about group 1087. Why not stacks, for example, Divine Spirit with Scroll of Strength. Not the same stat, at all.
// Some info: From wowhead(2007/09/21): http://www.wowhead.com/item=27498#comments:id=156055
They stack with any and all buffs EXCEPT player given buffs that buff a single stat.
So the intellect, spirit and stamina scrolls cannot stack with Arcane Intellect, Divine Spirit or Fortitude respectively.
But you can have a Str, Agi and Armour scroll equipped without any regard to normal raid buffs, elixirs and flasks.
The reason will be displayed to describe this comment to others. Learn more.
@Ryosan23: It's a typo, didn't intend it. Will commit something up later on @tkrokli: I left in deprecated groups just because, other expansions might find them useful from my list (I think just about every TBC stacking rule is incorporated, only cuts necessary)
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally! Great job.
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isnt still sql fix for GBOK+GBOS right?
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siley Right
That part needs some separate handling
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @Trisjdc ^^
Btw, could you give it a check at this other stack bug that is still present: #2706
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice!
Does this already include Improved Leader of the Pack (http://wotlk.openwow.com/spell=34297, http://wotlk.openwow.com/spell=34300)
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And how about the paladin auras especially when concerning Aura Mastery (http://wotlk.openwow.com/spell=31821)?
Shadow Resistance Aura: 19876 19895 19896 27151 48943
Fire Resistance Aura: 19891 19899 19900 27153 48947
Frost Resistance Aura: 19888 19897 19898 27152 48945
Devotion Aura: 465 10290 643 10291 1032 10292 10293 27149 48941 48942
Retribution Aura: 7294 10298 10299 10300 10301 27150 54043
Crusader Aura: 32223
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poisons are bad. Only One poison now can be on target.
example Deadly poison remove wound poison etc
in this are poison not critical
-- Target Critical Increase
+(1058, -1057),
+(1058, 2818),
+(1058, 3409),
+(1058, 5760),
+(1058, 21183),
+(1058, 30708),
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one scroll can be active? Scroll of stamina rewrite scroll of agility etc. Is that correct?
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siley Aye, even wowwiki states it: http://www.wowwiki.com/Scroll?oldid=2171963
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, honestly, great job.
Second, I've a question about group 1087. Why not stacks, for example, Divine Spirit with Scroll of Strength. Not the same stat, at all.
// Some info: From wowhead(2007/09/21): http://www.wowhead.com/item=27498#comments:id=156055
They stack with any and all buffs EXCEPT player given buffs that buff a single stat.
So the intellect, spirit and stamina scrolls cannot stack with Arcane Intellect, Divine Spirit or Fortitude respectively.
But you can have a Str, Agi and Armour scroll equipped without any regard to normal raid buffs, elixirs and flasks.
Thanks again ;)
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ryosan23: It's a typo, didn't intend it. Will commit something up later on
@tkrokli: I left in deprecated groups just because, other expansions might find them useful from my list (I think just about every TBC stacking rule is incorporated, only cuts necessary)
f278214There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added Enlightened (http://www.wowhead.com/spell=43722) from Skullfish Soup shouldn't have problems with other foods, i think.
I hpe u look this too, thanks again ;)