[3.3.5] [authserver] Unused variable in AuthSession

[Nefarion]

bool AuthSession._isAuthenticated (authserver project) is only written to, but never read from, so i wanted to know if it is really necessary to have it there.

It is used twice:
AuthSession::HandleLogonProof():574
AuthSession::HandleReconnectProof():725

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Shauren]

It should be used to check access to REALM_LIST packet (this was done before boost, maybe it got lost)

[Nefarion]

I already wondered why noone was checking for authed status in that function, would have been my next question :)
👍

Edit: This commit removed the check

[ghost]

Interesting. What would the advantage be of removing https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/authserver/Server/AuthSession.h#L74 if it is proven to be unused?