[3.3.5][6.x][Quest] To Legion Hold (10563) #13572

ccrs · 2014-11-16T16:42:21Z

This quest used to work, but now it doesnt :P

Nothing happens when spell http://www.wowhead.com/spell=37097 of item http://www.wowhead.com/item=30638 is used near the Legion Communication Device.

Also the spell transform player into an imp, not a box

http://www.wowhead.com/quest=10563

5e95a0f

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The text was updated successfully, but these errors were encountered:

xerkoss · 2014-11-16T17:56:46Z

UPDATE creature_template SET modelid1=20366, modelid2=0, modelid3=0, modelid4=0 WHERE entry=21629; -- to look like a box

missing event_scripts id 13852 for spell 37492.

Aokromes · 2014-11-16T19:21:04Z

spawping templates model id without sniff is hack.

[0] Display ID: 4449
[1] Display ID: 20366

Rushor · 2014-11-16T19:24:52Z

-- Box SAI
SET @ENTRY := 21629;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,0,0,54,0,100,0,0,0,0,0,3,0,20366,0,0,0,0,1,0,0,0,0,0,0,0,"Box - On Just Summoned - Morph To Model 20366");

:DDDDD

ccrs · 2014-11-16T20:04:59Z

eitherway thats only the cosmetic part :P
the main event isnt scripted or isnt triggered

xerkoss · 2014-11-16T20:19:46Z

Is this?
https://github.com/TrinityCore/TrinityCore/blob/98ca9a77491196ef501093572867236712d74938/sql/old/4.3.4/TDB4_to_TDB5_updates/world/022_2013_03_01_02_world_misc.sql

Rushor · 2014-11-16T20:42:15Z

thats the script for the quest - do you checked if your db is up to date?

ccrs · 2014-11-16T21:01:28Z

@Rushor sure it is. Thats a script from 2013, surely something got messed up since then

and quoting myself

This quest used to work, but now it doesnt :P

ccrs · 2014-11-16T21:18:15Z

Ok I found the problem here, the script only runs if player has the disguise aura on entering the trigger.

But, u cant enter the trigger with the aura as the aura disables movement on player.
Also, casting the spell inside trigger's area wont work as trigger scripts only run on entering them, there is no "update" or refresh.

xerkoss · 2014-11-16T22:21:00Z

@ccrs try this. maybe it solves.

SET @JOVAAN             := 21633; -- Deathbringer Jovaan
SET @TRIGGER            := 4548;  -- Smart Trigger
SET @DEVICE             := 184833;-- Legion Communication Device
SET @GO_INFERNAL        := 184834;-- Gobject that needs to be despawned during the script
SET @GO_INFERNAL2       := 184835;-- Gobject that needs to be despawned during the script
SET @EVENTID            := 13852; -- From spell_dbc id 37492


DELETE FROM `event_scripts` WHERE `id` =@EVENTID;
INSERT INTO `event_scripts` (`id`, `command`, `datalong`, `datalong2`, `x`, `y`, `z`, `o`) VALUES
(@EVENTID, 10, @JOVAAN, 57000, -3310.995, 2951.892, 171.2171, 5.5355);

DELETE FROM `areatrigger_scripts` WHERE `entry`=@TRIGGER;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@TRIGGER AND `source_type`=2;

UPDATE `gameobject_template` SET `AIName` ='' WHERE `entry` =@DEVICE;
DELETE FROM `smart_scripts` WHERE `source_type`=1 AND `entryorguid` =@DEVICE;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@JOVAAN AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(@JOVAAN,0,0,1,11,0,100,0,0,0,0,0,11,34427,0,0,0,0,0,1,0,0,0,0,0,0,0,'Deathbringer Jovaan - Just summoned - Spellcast Etheral Teleport'),
(@JOVAAN,0,1,2,61,0,100,0,0,0,0,0,45,0,1,0,0,0,0,14,25737,@GO_INFERNAL,0,0,0,0,0,'Deathbringer Jovaan - Just summoned - Set Data GO'),
(@JOVAAN,0,2,3,61,0,100,0,0,0,0,0,45,0,2,0,0,0,0,14,25738,@GO_INFERNAL2,0,0,0,0,0,'Deathbringer Jovaan - Just summoned Set Data GO'),
(@JOVAAN,0,3,0,61,0,100,0,0,0,0,0,53,0,@JOVAAN,0,0,0,0,1,0,0,0,0,0,0,0,'Deathbringer Jovaan - Just summoned - Start WP movement'),
(@JOVAAN,0,4,5,40,0,100,0,4,@JOVAAN,0,0,54,45000,0,0,0,0,0,1,0,0,0,0,0,0,0,'Deathbringer Jovaan - On WP 4 reached - Pause 45 seconds'),
(@JOVAAN,0,5,0,61,0,100,0,0,0,0,0,80,@JOVAAN*100,2,0,0,0,0,1,0,0,0,0,0,0,0,'Deathbringer Jovaan - On WP 4 reached - Run Script');

ccrs · 2014-11-16T23:51:31Z

Umm seems legit, but can u explain the trigger part? I mean

SET @EVENTID := 13852; -- From spell_dbc id 37492

and

DELETE FROM event_scripts WHERE id =@EVENTID;
INSERT INTO event_scripts (id, command, datalong, datalong2, x, y, z, o) VALUES
(@EVENTID, 10, @JOVAAN, 57000, -3310.995, 2951.892, 171.2171, 5.5355);

does the spell trigger it? spell_dbc sais something like generic disguise

xerkoss · 2014-11-17T00:14:55Z

Id: 37097
Name: Crate Disguise
...
Effect 2:
Id: 64 (SPELL_EFFECT_TRIGGER_SPELL)
BasePoints = 1
Targets (1, 0) (TARGET_SELF, NO_TARGET)
Trigger spell: 37492 Not found

that not found spell has effect aply aura stuned + effect send event 13852. 335 - 434 I don't know how works now in wod the spell_dbc table.

ccrs · 2014-11-17T00:23:10Z

spell_scripts: Holds scripts that can be activated by spells with effect SPELL_EFFECT_SCRIPT_EFFECT (77) or SPELL_EFFECT_DUMMY(3).

I think u should change it into a spell_script, or so it seems.

some feedback form devs would be great xD

xerkoss · 2014-11-17T00:25:58Z

Id: 61 (SPELL_EFFECT_SEND_EVENT).

ccrs · 2014-11-17T00:30:13Z

ok, then ill try it.

just some format

SET @JOVAAN := 21633; -- Deathbringer Jovaan
SET @TRIGGER := 4548; -- Smart Trigger
SET @DEVICE := 184833;-- Legion Communication Device
SET @GO_INFERNAL := 184834;-- Gobject that needs to be despawned during the script
SET @GO_INFERNAL2 := 184835;-- Gobject that needs to be despawned during the script
SET @EVENTID := 13852; -- From spell_dbc id 37492

DELETE FROM event_scripts WHERE id =@EVENTID;
INSERT INTO event_scripts (id, command, datalong, datalong2, x, y, z, o) VALUES
(@EVENTID, 10, @JOVAAN, 57000, -3310.995, 2951.892, 171.2171, 5.5355);

DELETE FROM areatrigger_scripts WHERE entry=@TRIGGER;
DELETE FROM smart_scripts WHERE entryorguid=@TRIGGER AND source_type=2;

UPDATE gameobject_template SET AIName ='' WHERE entry =@DEVICE;
DELETE FROM smart_scripts WHERE source_type=1 AND entryorguid =@DEVICE;

DELETE FROM smart_scripts WHERE entryorguid=@JOVAAN AND source_type=0;
INSERT INTO smart_scripts (entryorguid, source_type, id, link, event_type, event_phase_mask, event_chance, event_flags, event_param1, event_param2, event_param3, event_param4, action_type, action_param1, action_param2, action_param3, action_param4, action_param5, action_param6, target_type, target_param1, target_param2, target_param3, target_x, target_y, target_z, target_o, comment) VALUES
(@JOVAAN,0,0,1,11,0,100,0,0,0,0,0,11,34427,0,0,0,0,0,1,0,0,0,0,0,0,0,'Deathbringer Jovaan - Just summoned - Spellcast Etheral Teleport'),
(@JOVAAN,0,1,2,61,0,100,0,0,0,0,0,45,0,1,0,0,0,0,14,25737,@GO_INFERNAL,0,0,0,0,0,'Deathbringer Jovaan - Just summoned - Set Data GO'),
(@JOVAAN,0,2,3,61,0,100,0,0,0,0,0,45,0,2,0,0,0,0,14,25738,@GO_INFERNAL2,0,0,0,0,0,'Deathbringer Jovaan - Just summoned Set Data GO'),
(@JOVAAN,0,3,0,61,0,100,0,0,0,0,0,53,0,@JOVAAN,0,0,0,0,1,0,0,0,0,0,0,0,'Deathbringer Jovaan - Just summoned - Start WP movement'),
(@JOVAAN,0,4,5,40,0,100,0,4,@JOVAAN,0,0,54,45000,0,0,0,0,0,1,0,0,0,0,0,0,0,'Deathbringer Jovaan - On WP 4 reached - Pause 45 seconds'),
(@JOVAAN,0,5,0,61,0,100,0,0,0,0,0,80,@JOVAAN*100,2,0,0,0,0,1,0,0,0,0,0,0,0,'Deathbringer Jovaan - On WP 4 reached - Run Script');

ccrs · 2014-11-18T15:44:30Z

Works Perfectly, ty @xerkoss

xerkoss · 2014-11-18T16:26:30Z

@ccrs :D remove remaining conditions & put new one for spell when there is no Deathbringer Jovaan present. And that's all.

dr-j · 2014-11-21T00:41:04Z

Actually the reason why this quest no longer works is because of a spell in spell_dbc

INSERT INTO `spell_dbc` (`Id`, `Dispel`, `Mechanic`, `Attributes`, `AttributesEx`, `AttributesEx2`, `AttributesEx3`, `AttributesEx4`, `AttributesEx5`, `AttributesEx6`, `AttributesEx7`, `Stances`, `StancesNot`, `Targets`, `CastingTimeIndex`, `AuraInterruptFlags`, `ProcFlags`, `ProcChance`, `ProcCharges`, `MaxLevel`, `BaseLevel`, `SpellLevel`, `DurationIndex`, `RangeIndex`, `StackAmount`, `EquippedItemClass`, `EquippedItemSubClassMask`, `EquippedItemInventoryTypeMask`, `Effect1`, `Effect2`, `Effect3`, `EffectDieSides1`, `EffectDieSides2`, `EffectDieSides3`, `EffectRealPointsPerLevel1`, `EffectRealPointsPerLevel2`, `EffectRealPointsPerLevel3`, `EffectBasePoints1`, `EffectBasePoints2`, `EffectBasePoints3`, `EffectMechanic1`, `EffectMechanic2`, `EffectMechanic3`, `EffectImplicitTargetA1`, `EffectImplicitTargetA2`, `EffectImplicitTargetA3`, `EffectImplicitTargetB1`, `EffectImplicitTargetB2`, `EffectImplicitTargetB3`, `EffectRadiusIndex1`, `EffectRadiusIndex2`, `EffectRadiusIndex3`, `EffectApplyAuraName1`, `EffectApplyAuraName2`, `EffectApplyAuraName3`, `EffectAmplitude1`, `EffectAmplitude2`, `EffectAmplitude3`, `EffectMultipleValue1`, `EffectMultipleValue2`, `EffectMultipleValue3`, `EffectItemType1`, `EffectItemType2`, `EffectItemType3`, `EffectMiscValue1`, `EffectMiscValue2`, `EffectMiscValue3`, `EffectMiscValueB1`, `EffectMiscValueB2`, `EffectMiscValueB3`, `EffectTriggerSpell1`, `EffectTriggerSpell2`, `EffectTriggerSpell3`, `EffectSpellClassMaskA1`, `EffectSpellClassMaskA2`, `EffectSpellClassMaskA3`, `EffectSpellClassMaskB1`, `EffectSpellClassMaskB2`, `EffectSpellClassMaskB3`, `EffectSpellClassMaskC1`, `EffectSpellClassMaskC2`, `EffectSpellClassMaskC3`, `MaxTargetLevel`, `SpellFamilyName`, `SpellFamilyFlags1`, `SpellFamilyFlags2`, `SpellFamilyFlags3`, `MaxAffectedTargets`, `DmgClass`, `PreventionType`, `DmgMultiplier1`, `DmgMultiplier2`, `DmgMultiplier3`, `AreaGroupId`, `SchoolMask`, `Comment`) VALUES
(37492, 0, 0, 384, 268435456, 0, 0, 4, 0, 0, 0, 0, 0, 0, 1, 0, 0, 101, 0, 0, 0, 0, 3, 1, 0, -1, 0, 0, 6, 61, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 12, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 13852, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 0, 1, 'Crate Disguise Subspell');

Remove this and the quest works as before this is the spell which is responsible for preventing you from moving while disguised as a box but the problem with this is that the spellfocus to use the box and the areatrigger are not exactly in same space so after using the item at spellfocus you must move to hit the areatrigger, it is impossible to be in a position to use the box and be on the areatrigger at the same time,

Apart from this it still works

Suggestion, Move the spellfocus object to same position as areatrigger

xerkoss · 2014-11-21T01:15:05Z

A jumping or dancing box around looks more blizzlike? No sense.

dr-j · 2014-11-21T02:56:01Z

ye what im trying to get at is that unless spell focus is moved its impossible to complete quest in its current state, as said when you are at spellfocus so you can use the disguise you dont hit areatrigger unless you move and if you stand on areatrigger you are too far from spellfocus to use item,

basically because the spellfocus and areatrigger are not on same spot you cant trigger event without moving once you have used the disguise

ccrs · 2014-11-21T15:47:41Z

Thats what i reported some days ago, @dr-j.

But, i think his solution is better and also, more blizzlike.

Aokromes · 2015-02-12T07:27:26Z

Anything here is valid? imho dr-j's sugestion of move spellfocus is correct.

Aokromes · 2015-04-01T09:47:25Z

Areatrigger of Legion Hold:
4548 530 -3300.379883 2927.280029 170.938004 0.00 10.00 10.00 10.00 0.00

Try:

UPDATE `gameobject` SET `position_x`=-3300.5, `position_y`=2927.280029, `position_z`=170.938004 WHERE `guid`=99974;

xerkoss · 2015-04-01T10:27:16Z

I still think you should not be able to move and it's triggered by event. You are thinking "If mahoma doesn't go to the mountain.. the mountain will go to mahoma", and that was no sense.

Aokromes · 2015-04-01T10:51:19Z

I am not moving the mountain (areatrigger) instead mahoma (spellfocus) :P

ccrs · 2015-04-01T13:18:01Z

why trying to change data if the other fix was valid and blizzlike?

Aokromes · 2015-04-01T13:19:56Z

Because spell focus can't be sniffed and it was spawned on different coordinates to area trigger. If the fix is correct with 1 row, why push 20?

Killyana · 2015-04-01T15:19:06Z

The problem is not the position of the spell focus or the dbcspell 37492, but that the event (Smart Trigger - On Trigger - Set Data to GO) will not trigger if the player is not moving with the disguise, maybe related to this issue: #1031

ccrs · 2015-04-01T18:01:16Z

EXACTLY xD

There is no refresh or update option in areatriggers, so scripts will only trigger at player enter

Jenkyins · 2016-01-29T16:39:07Z

confirmed on b1d0855 the quest doesn't work actually.

@xerkoss

By @xerkoss Closes #13572 Ok I was skeptical of this fix too when I fist saw it but has been proven to solve issues with this quest ie event always triggers when player obtains the Crate Disguise Subspell, this is just changing the event from been triggered on areatrigger to been triggered by event id used by spell

@xerkoss

By @xerkoss Closes #13572 Ok I was skeptical of this fix too when I fist saw it but has been proven to solve issues with this quest ie event always triggers when player obtains the Crate Disguise Subspell, this is just changing the event from been triggered on areatrigger to been triggered by event id used by spell (cherry picked from commit 4daaf69)

Aokromes added the Comp-Database label Nov 20, 2014

Aokromes added the Feedback-FixOutdatedMissingWIP label Feb 12, 2015

Aokromes added the Sub-Quests label Feb 15, 2015

Killyana mentioned this issue Aug 21, 2015

Inn rested state fades too early #15325

Closed

Rushor changed the title ~~[Quest] To Legion Hold (10563)~~ 3.3.5][6.x][Quest] To Legion Hold (10563) Feb 8, 2016

Rushor changed the title ~~3.3.5][6.x][Quest] To Legion Hold (10563)~~ [3.3.5][6.x][Quest] To Legion Hold (10563) Feb 8, 2016

TrinityCoreBot closed this as completed Feb 8, 2016

TrinityCoreBot mentioned this issue Feb 8, 2016

[DEV] Changelog (TDB: 335.61 & 6.04) #15821

Closed

TrinityCoreBot mentioned this issue Feb 8, 2016

[DEV] 3.3.5 -> 6.x cherry-picks (TDB: 335.61 & 6.04) #15819

Closed

Aokromes removed the Feedback-FixOutdatedMissingWIP label Aug 16, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3.3.5][6.x][Quest] To Legion Hold (10563) #13572

[3.3.5][6.x][Quest] To Legion Hold (10563) #13572

ccrs commented Nov 16, 2014

xerkoss commented Nov 16, 2014

Aokromes commented Nov 16, 2014

Rushor commented Nov 16, 2014

ccrs commented Nov 16, 2014

xerkoss commented Nov 16, 2014

Rushor commented Nov 16, 2014

ccrs commented Nov 16, 2014

ccrs commented Nov 16, 2014

xerkoss commented Nov 16, 2014

ccrs commented Nov 16, 2014

xerkoss commented Nov 17, 2014

ccrs commented Nov 17, 2014

xerkoss commented Nov 17, 2014

ccrs commented Nov 17, 2014

ccrs commented Nov 18, 2014

xerkoss commented Nov 18, 2014

dr-j commented Nov 21, 2014

xerkoss commented Nov 21, 2014

dr-j commented Nov 21, 2014

ccrs commented Nov 21, 2014

Aokromes commented Feb 12, 2015

Aokromes commented Apr 1, 2015

xerkoss commented Apr 1, 2015

Aokromes commented Apr 1, 2015

ccrs commented Apr 1, 2015

Aokromes commented Apr 1, 2015

Killyana commented Apr 1, 2015

ccrs commented Apr 1, 2015

Jenkyins commented Jan 29, 2016

[3.3.5][6.x][Quest] To Legion Hold (10563) #13572

[3.3.5][6.x][Quest] To Legion Hold (10563) #13572

Comments

ccrs commented Nov 16, 2014

xerkoss commented Nov 16, 2014

Aokromes commented Nov 16, 2014

Rushor commented Nov 16, 2014

ccrs commented Nov 16, 2014

xerkoss commented Nov 16, 2014

Rushor commented Nov 16, 2014

ccrs commented Nov 16, 2014

ccrs commented Nov 16, 2014

xerkoss commented Nov 16, 2014

ccrs commented Nov 16, 2014

xerkoss commented Nov 17, 2014

ccrs commented Nov 17, 2014

xerkoss commented Nov 17, 2014

ccrs commented Nov 17, 2014

ccrs commented Nov 18, 2014

xerkoss commented Nov 18, 2014

dr-j commented Nov 21, 2014

xerkoss commented Nov 21, 2014

dr-j commented Nov 21, 2014

ccrs commented Nov 21, 2014

Aokromes commented Feb 12, 2015

Aokromes commented Apr 1, 2015

xerkoss commented Apr 1, 2015

Aokromes commented Apr 1, 2015

ccrs commented Apr 1, 2015

Aokromes commented Apr 1, 2015

Killyana commented Apr 1, 2015

ccrs commented Apr 1, 2015

Jenkyins commented Jan 29, 2016