[3.3.5] Share Quest does not work if quest objective is complete

[ghost]

branch: 3.3.5
rev: f377a58

When you try to share a quest while in a group, the quest will only share if the objective is incomplete.

This makes most(if not all) quests where the objective is to speak to another NPC un-shareable, as the objective is complete the moment you accept the quest.

How to replicate:
-Make 2 dwarves on 2 accounts.
-Group up
-Accept very first dwarf quest on 1 character
-At this point, it IS sharable.
-complete the quest, but don't hand it in (.quest complete questID)
-Quest can no longer be shared. (edit: Share button can be clicked, but does nothing)

[Treeston]

Define "can no longer be shared". The button is greyed out, or the button does nothing?

[ghost]

Sorry.

The button is clickable, but does nothing when clicked.

[Killyana]

Confirm, I was thinking it is the retail behavior.

[ghost]

I can't see it being retail behavior, but maybe I remember wrath wrong... it makes any quest with an auto complete objective (quests that require you to go to another npc) impossible to share, despite them having the shareable flag.

[Treeston]

Pretty sure it isn't retail behavior (especially since UI indicates the quest should still be sharable).

[ghost]

CanShareQuest() check inside QuestHandler.cpp seems to be contributing to this issue?

[ghost]

I agree 100% with you, @Treeston. If a quest is not supposed to be shareable, it should not have the button enabled in the first place. Either the quest flags are wrong, or the sharing functionality is bugged.

[Aokromes]

humm, the "very first dwarf quest" is not sharable for me, nor on tc, nor on retail.

[ghost]

#179
isn't shareable for you?

[Aokromes]

nope.

[ghost]

Are you able to accept a quest on one character that you know is shareable, complete the objective, and then share it with another player?