Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3.5][Ulduar] Core/Gameobject Yogg-Saron Portals #16390

Closed
ghost opened this issue Jan 25, 2016 · 5 comments
Closed

[3.3.5][Ulduar] Core/Gameobject Yogg-Saron Portals #16390

ghost opened this issue Jan 25, 2016 · 5 comments

Comments

@ghost
Copy link

ghost commented Jan 25, 2016

Clicking them causes the portal to despawn, but you're not actually ported.

Related spellclick spells: 63989, 63997, 63998

Portals: 34072

Rev e6a7818

@Rushor
Copy link
Contributor

Rushor commented Jan 26, 2016

hm

are these datas this in the db?

DELETE FROM `spell_target_position` WHERE `id` IN (63989,63997,63998,63992);
INSERT INTO `spell_target_position` (`id`,`target_map`,`target_position_x`,`target_position_y`,`target_position_z`,`target_orientation`) VALUES
(63989,603,1954.14,21.522,239.718,2.09439),
(63997,603,2043.12,-25.6981,239.721,0),
(63998,603,1949.13,-80.6744,239.99,4.18879),
(63992,603,1970.61,-25.5988,324.55,3.10346);

https://github.com/TrinityCore/TDB_4.3.4_NLU/blob/master/old/updates_04/067_2013_05_14_00_world_instance_ulduar.sql#L369

@Rushor
Copy link
Contributor

Rushor commented Jan 26, 2016

hm are these datas still in the db?

https://github.com/TrinityCore/TDB_4.3.4_NLU/blob/master/old/updates_04/067_2013_05_14_00_world_instance_ulduar.sql#L369

DELETE FROM `spell_target_position` WHERE `id` IN (63989,63997,63998,63992);
INSERT INTO `spell_target_position` (`id`,`target_map`,`target_position_x`,`target_position_y`,`target_position_z`,`target_orientation`) VALUES
(63989,603,1954.14,21.522,239.718,2.09439),
(63992,603,1970.61,-25.5988,324.55,3.10346),
(63997,603,2043.12,-25.6981,239.721,0),
(63998,603,1949.13,-80.6744,239.99,4.18879);

(need update to current db definitions)

@ghost
Copy link
Author

ghost commented Jan 26, 2016

Yeah, the spell click teleport data is there

@ghost
Copy link

ghost commented Jan 27, 2016

From 335.60

SELECT * FROM `spell_target_position` WHERE `id` IN (63989,63997,63998,63992);
    ID  EffectIndex   MapID  PositionX  PositionY  PositionZ  Orientation  VerifiedBuild  
------  -----------  ------  ---------  ---------  ---------  -----------  ---------------
 63989            0     603    1954.14     21.522    239.718      2.09439                0
 63992            0     603    1970.61   -25.5988     324.55      3.10346                0
 63997            0     603    2043.12   -25.6981    239.721            0                0
 63998            0     603    1949.13   -80.6744     239.99      4.18879                0

Appears they were updated.

@Rushor Rushor changed the title [3.3.5] Yogg-Saron Portals [3.3.5][Ulduar] Core/Gameobject Yogg-Saron Portals Feb 9, 2016
@sirikfoll
Copy link
Contributor

I do not know why it stopped working, in rev 52692c3 it was working well.

But, this can fix it and it is not a hack:

diff --git a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp
index 7da6717..869592c 100644
--- a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp
+++ b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp
@@ -230,6 +230,9 @@ enum Spells

     // Descend Into Madness
     SPELL_TELEPORT_PORTAL_VISUAL            = 64416,
+    SPELL_TELEPORT_TO_STORMWIND_ILLUSION    = 63989,
+    SPELL_TELEPORT_TO_CHAMBER_ILLUSION      = 63997,
+    SPELL_TELEPORT_TO_ICECROWN_ILLUSION     = 63998,

     // Illusions
     SPELL_GRIM_REPRISAL                     = 63305,
@@ -395,6 +398,14 @@ enum MiscData
 {
     ACHIEV_TIMED_START_EVENT                = 21001,
     SOUND_LUNATIC_GAZE                      = 15757,
+    MAX_ILLUSION_CHAMBERS                   = 3
+};
+
+uint32 const IllusionSpells[MAX_ILLUSION_CHAMBERS]
+{
+    SPELL_TELEPORT_TO_CHAMBER_ILLUSION,
+    SPELL_TELEPORT_TO_ICECROWN_ILLUSION,
+    SPELL_TELEPORT_TO_STORMWIND_ILLUSION,
 };

 class StartAttackEvent : public BasicEvent
@@ -1419,7 +1430,9 @@ class npc_descend_into_madness : public CreatureScript
             {
                 if (!result)
                     return;
+
                 clicker->RemoveAurasDueToSpell(SPELL_BRAIN_LINK);
+                me->CastSpell(clicker, IllusionSpells[_instance->GetData(DATA_ILLUSION)], true);
                 me->DespawnOrUnsummon();
             }
DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=18 AND `SourceEntry` IN (63989,63997,63998);
DELETE FROM `npc_spellclick_spells` WHERE `npc_entry`=34072;
INSERT INTO `npc_spellclick_spells` (`npc_entry`, `spell_id`, `cast_flags`, `user_type`) VALUES
(34072, 51347, 1, 0);

joschiwald pushed a commit that referenced this issue Mar 4, 2016
P-Kito pushed a commit to P-Kito/TrinityCore that referenced this issue Mar 27, 2016
Shauren pushed a commit that referenced this issue Apr 8, 2016
Closes #16390
Closes #16708

(cherry picked from commit c4e4ee3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants