New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.3.5] Format Exception Crashes #16751
Labels
Comments
Here's a side-by-side of all lines changed by that commit, if someone could go through them. |
Only speed related ones seem to have issues: 137, 139, 141, 143, 145, 147 |
ghost
self-assigned this
Mar 9, 2016
This was referenced Mar 9, 2016
P-Kito
pushed a commit
to P-Kito/TrinityCore
that referenced
this issue
Mar 27, 2016
… a recent commit Ref TrinityCore#16648 Closes TrinityCore#16751
Naios
pushed a commit
to Naios/TrinityCore
that referenced
this issue
May 1, 2016
… a recent commit Ref TrinityCore#16648 Closes TrinityCore#16751 (cherry picked from commit c190577)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behaviour: Tell us what happens
Using certain commands crashes the server because even though the text was changed, the order which the params are sent at core is still the same, resulting in a format exception crash.
https://gist.github.com/Nyeriah/1531b1285a6b667779cb
Steps to reproduce the problem:
Branch(es): 335
TC hash/commit: a41bd8e
Blame goes to 7ee7548
I have managed to crash it with both mod speed and mod size, I haven't tested all of them but I wonder if there are more of these text changes that haven't been tested and could produce the same result.
https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/Commands/cs_modify.cpp#L476
The text was updated successfully, but these errors were encountered: