Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core/Network: Socket<T>::DelayedCloseSocket() is not delayed #16769

Closed
joschiwald opened this issue Mar 12, 2016 · 0 comments
Closed

Core/Network: Socket<T>::DelayedCloseSocket() is not delayed #16769

joschiwald opened this issue Mar 12, 2016 · 0 comments

Comments

@joschiwald
Copy link
Contributor

Description: Socket::DelayedCloseSocket() is not delayed, socket is closed immediately if your server is running under unix with TC_SOCKET_USE_IOCP disabled

Current behaviour: You don't receive any queued packet after the socket is marked for closing.

Expected behaviour: You should receive all queued packets after the socket is marked for closing until the queue is empty.

Steps to reproduce the problem:

Scenario 1:

  1. close your world with .server set closed
  2. try to login
  3. you will lost connection to server and don't receive the correct message

Scenario 2:

  1. log into authserver, stay in realmlist
  2. ban your account
  3. log into worldserver
  4. you will lost connection to server and don't receive the account banned message

Branch(es): 335 (6x not tested)

TC hash/commit: cebe612

TDB version: 335.60

Operating system: Ubuntu 15.10
This was referenced Mar 12, 2016
Closed
Closed
Shauren added a commit that referenced this issue Mar 12, 2016
@Shauren
Core/Networking: Fixed DelayedCloseSocket when compiled without TC_SO…
9b5adcc 
…CKET_USE_IOCP (linux)

Closes #16769

(cherry picked from commit 0daba93)
@TrinityCoreBot TrinityCoreBot mentioned this issue Mar 12, 2016
Closed
P-Kito pushed a commit to P-Kito/TrinityCore that referenced this issue Mar 27, 2016
@Shauren @P-Kito
Core/Networking: Fixed DelayedCloseSocket when compiled without TC_SO…
efeeb27 
…CKET_USE_IOCP (linux)

Closes TrinityCore#16769

(cherry picked from commit 0daba93)
Aokromes pushed a commit to Aokromes/TrinityCore that referenced this issue May 4, 2016
@Shauren @Aokromes
Core/Networking: Fixed DelayedCloseSocket when compiled without TC_SO…
ddb85e2 
…CKET_USE_IOCP (linux)

Closes TrinityCore#16769

(cherry picked from commit 0daba93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joschiwald