[3.3.5][6.x]Cabal Ritualists don't cast Crystal Channel

[ghost]

Cabal Ritualists in Shadow Labs do not channel the spell Crystal Channel. I have tried adding it to their smart scripts via the following query:

Current fix. Still have issues where not all the ritualists will cast the spell on the invisible target. However, the ones that are bugged will start casting it on the target after they reset due to aggro drop. Additionally, the mobs seem to stop casting the spell on the invisible target when you get a certain bit out of range from them. (For instance if you run to the door by blackheart the inciter in the next room). Maybe that issue is why not all of them appear to be casting it on the invisible target? They are too far from the instance entrance? (Thanks Ulduar for the conditions part.)

DELETE FROM `smart_scripts` WHERE `entryorguid`=18794 AND `id`=34;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(18794,0,34,0,1,0,100,0,0,0,0,0,11,32958,0,0,0,0,0,1,0,0,0,0,0,0,0,"Cabal Ritualist - Out of Combat - Cast 'Crystal Channel'");

DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=13 AND `SourceGroup`=0 AND `SourceEntry`=32958;
INSERT INTO `conditions` (`SourceTypeOrReferenceId`,`SourceGroup`,`SourceEntry`,`SourceId`,`ElseGroup`,`ConditionTypeOrReference`,`ConditionTarget`,`ConditionValue1`,`ConditionValue2`,`ConditionValue3`,`ErrorTextId`,`ScriptName`,`Comment`) VALUES
(13,1,32958,0,0,31,0,3,18793,0,0,"","Crystal Channel – Effect 0 - Cast only on Invisible Target 18793.");

The spell will cast on the person casting and not a target (presumably it is supposed to be cast on Invisible Target which is spawned in the correct spot). solved below

I got the spell id from ACID scripting for cmangos TBC which I believe comes from sniff data? Confirmed by Ulduar from a 4.3.4 sniff.

Branch(es): 335/6x

TC hash/commit: dc39de0

TDB version: TDB 335.60

[ghost]

I got the spell id from ACID scripting for cmangos TBC which I believe comes from sniff data?

Yes, from sniff 4.3.4 data.

ID - 32958 Канал кристалла
=================================================

Category = 0, SpellIconID = 1919, activeIconID = 0, SpellVisual = (8008,0)
Family SPELLFAMILY_GENERIC, flag [0] 0x00000000 [1] 0x00000000 [2] 0x00000000 [3] 0x00000000

SpellSchoolMask = 1 (SPELL_SCHOOL_MASK_NORMAL)
DamageClass = 0 (SPELL_DAMAGE_CLASS_NONE)
PreventionType = 0 (SPELL_PREVENTION_TYPE_NONE)
=================================================
Attributes: 0x08400180 (SPELL_ATTR0_HIDDEN_CLIENTSIDE, SPELL_ATTR0_HIDE_IN_COMBAT_LOG, SPELL_ATTR0_CAST_TRACK_TARGET, SPELL_ATTR0_CASTABLE_WHILE_SITTING)
AttributesEx1: 0x10000004 (SPELL_ATTR1_CHANNELED_1, SPELL_ATTR1_DONT_DISPLAY_IN_AURA_BAR)
AttributesEx2: 0x00000004 (SPELL_ATTR2_CAN_TARGET_NOT_IN_LOS)
=================================================
Spell Level = 0, base 0, max 0

Category = 0
DispelType = 0 (DISPEL_NONE)
Mechanic = 0 (MECHANIC_NONE)
SpellRange: (Id 11) "Fifteen yards":
    MinRangeNegative = 0, MinRangePositive = 0
    MaxRangeNegative = 15, MaxRangePositive = 15

Cast time (Id 1) = 0,00
Duration: ID (21)  -1, 0, -1
Interrupt Flags: 0x0000000F, AuraIF 0x00001007, ChannelIF 0x00003C07
Chance = 0, charges - 0
=================================================
Effect 0: Id 6 (SPELL_EFFECT_APPLY_AURA) DIFFICULTY_NONE
BasePoints = 1
Targets (38, 0) (TARGET_UNIT_NEARBY_ENTRY, NO_TARGET)
Aura Id 4 (SPELL_AURA_DUMMY), value = 1, misc = 0 (0), miscB = 0, periodic = 0

Effect 1: Id 6 (SPELL_EFFECT_APPLY_AURA) DIFFICULTY_NONE
BasePoints = 0
Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)
Aura Id 4 (SPELL_AURA_DUMMY), value = 0, misc = 0 (0), miscB = 0, periodic = 0

Also if missing in TDB, add condition for spell target:

DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=13 AND `SourceGroup`=0 AND `SourceEntry`=32958;
INSERT INTO `conditions` (`SourceTypeOrReferenceId`,`SourceGroup`,`SourceEntry`,`SourceId`,`ElseGroup`,`ConditionTypeOrReference`,`ConditionTarget`,`ConditionValue1`,`ConditionValue2`,`ConditionValue3`,`ErrorTextId`,`ScriptName`,`Comment`) VALUES
(13,1,32958,0,0,31,0,3,18793,0,0,"","Crystal Channel – Effect 0 - Cast only on Invisible Target 18793.");

[ghost]

Just figured out the condition thing and you beat me to it! The problem is now that the spawns appear to be slightly off, as some will still cast it on themselves. (the spell has a 15 yrd range.)

Using this query with the condition from Ulduar.

DELETE FROM `smart_scripts` WHERE `entryorguid`=18794 AND `id`=34;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(18794,0,34,0,1,0,100,0,0,0,0,0,11,32958,0,0,0,0,0,1,0,0,0,0,0,0,0,"Cabal Ritualist - Out of Combat - Cast 'Crystal Channel'");

DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=13 AND `SourceGroup`=0 AND `SourceEntry`=32958;
INSERT INTO `conditions` (`SourceTypeOrReferenceId`,`SourceGroup`,`SourceEntry`,`SourceId`,`ElseGroup`,`ConditionTypeOrReference`,`ConditionTarget`,`ConditionValue1`,`ConditionValue2`,`ConditionValue3`,`ErrorTextId`,`ScriptName`,`Comment`) VALUES
(13,1,32958,0,0,31,0,3,18793,0,0,"","Crystal Channel – Effect 0 - Cast only on Invisible Target 18793.");

[ghost]

Repair condition comment please. Condition system support for guid also. But no more three targets.

[ghost]

I don't understand what you mean by that, Ulduar.

After further testing, the NPCs will properly cast on the invisible target after they reset due to aggro drop.

[ghost]

(13,1,32958,0,0,31,0,3,18793 ,0,0,"","Crystal Channel – Cast only on Invisible Target 18793.");

Replace please on

(13,1,32958,0,0,31,0,3,18793,0,0,"","Crystal Channel – Effect 0 - Cast only on Invisible Target 18793.");

Condition commend XD
Trinity SQL codding standart 😉

[Aokromes]

What of all is valid here? if the thing from Ulduar, plz, create one proper update query.

[ghost]

I already included it in the query in the initial report.

[Aokromes]

There is no need to delete+insert to change 1 cell.

[ghost]

If I recall correctly neither query is updating an existing row. Both rows should be new entries.

[Aokromes]

Ahh ok, i had the idea of the row from ulduar was rename of existing row :)

[msoky]

you deleted SourceGroup=0 and added SourceGroup=1 in (13,1,32958....