[335] SQL - Wrong gossip for Byancie (creature 6094)

[MrSmite]

Description:

The gossip for Byancie, the First Aid trainer in Dolanaar has the wrong NPC name in it

Current behaviour:

When you open the gossip menu, it says "I require training, Nissa"

Expected behaviour:

It should say "I require training, Byancie"

Steps to reproduce the problem:

1. Go to Dolanaar
2. Enter the tree next to the inn
3. Right-click on Byancie the First Aid trainer

Branch(es): 3.3.5

TC hash/commit: 2db9269

TDB version: TDB_full_world_335.61_2016_04_11.sql + updates

Operating system: Win XP / Win 7

Suggested Fix:

NOTE:

This does not work even though 4762 is the gossip id for Byancie. Also deleting the cache after this change did not work. Still shows 'Nissa' in game.

UPDATE `gossip_menu_option` SET `option_text`='I require training, Byancie.' WHERE `menu_id`=4762 AND `id`=0;

[Aokromes]

It looks 5150 and 6094 shares the same gossip_menu_id.

[ghost]

Yes, it is in creature_template. I also tried to search broadcast_text for the suggested text, but no luck.

SELECT * FROM `creature_template` WHERE `gossip_menu_id`= 4762;

entry  difficulty_entry_1  difficulty_entry_2  difficulty_entry_3  KillCredit1  KillCredit2  modelid1  modelid2  modelid3  modelid4  name             subname            IconName  gossip_menu_id  minlevel  maxlevel     exp  faction  npcflag  speed_walk  speed_run   scale    rank  dmgschool  BaseAttackTime  RangeAttackTime  BaseVariance  RangeVariance  unit_class  unit_flags  unit_flags2  dynamicflags  family  trainer_type  trainer_spell  trainer_class  trainer_race    type  type_flags  lootid  pickpocketloot  skinloot  resistance1  resistance2  resistance3  resistance4  resistance5  resistance6  spell1  spell2  spell3  spell4  spell5  spell6  spell7  spell8  PetSpellDataId  VehicleId  mingold  maxgold  AIName  MovementType  InhabitType  HoverHeight  HealthModifier  ManaModifier  ArmorModifier  DamageModifier  ExperienceModifier  RacialLeader  movementId  RegenHealth  mechanic_immune_mask  flags_extra  ScriptName  VerifiedBuild
-----  ------------------  ------------------  ------------------  -----------  -----------  --------  --------  --------  --------  ---------------  -----------------  --------  --------------  --------  --------  ------  -------  -------  ----------  ---------  ------  ------  ---------  --------------  ---------------  ------------  -------------  ----------  ----------  -----------  ------------  ------  ------------  -------------  -------------  ------------  ------  ----------  ------  --------------  --------  -----------  -----------  -----------  -----------  -----------  -----------  ------  ------  ------  ------  ------  ------  ------  ------  --------------  ---------  -------  -------  ------  ------------  -----------  -----------  --------------  ------------  -------------  --------------  ------------------  ------------  ----------  -----------  --------------------  -----------  ----------  -------------
 5150                   0                   0                   0            0            0      3068         0         0         0  Nissa Firestone  First Aid Trainer  (NULL)              4762        35        35       0       55       83           1    1.14286       1       0          0            2000             2000             1              1           1         512         2048             0       0             2              0              0             0       7   134217728       0               0         0            0            0            0            0            0            0       0       0       0       0       0       0       0       0               0          0        1      439                     0            3            1             1.1             1              1               1                   1             0           0            1                     0            2                      12340
 6094                   0                   0                   0            0            0      4862         0         0         0  Byancie          First Aid Trainer  (NULL)              4762        22        22       0       80       83           1    1.14286       1       0          0            2000             2000             1              1           1         512         2048             0       0             2              0              0             0       7   134217728       0               0         0            0            0            0            0            0            0       0       0       0       0       0       0       0       0               0          0        0        0                     0            3            1            1.02             1              1               1                   1             0           0            1                     0            2                      12340

All texts in broadcast_text (TDB 335.61 + all updates) containing %I require training% :

SELECT * FROM `broadcast_text` WHERE `MaleText` LIKE '%I require training%';

   ID  Language  MaleText                                   FemaleText                                 EmoteID0  EmoteID1  EmoteID2  EmoteDelay0  EmoteDelay1  EmoteDelay2  SoundId    Unk1    Unk2  VerifiedBuild
-----  --------  -----------------------------------------  -----------------------------------------  --------  --------  --------  -----------  -----------  -----------  -------  ------  ------  -------------
 2756         0  I require training.                        I require training.                               0         0         0            0            0            0        0       0       1          18019
 3022         0  Greetings Erion, I require training!       Greetings Erion, I require training!              0         0         0            0            0            0        0       0       1          18019
 3143         0  I require training, sir!                   I require training, sir!                          0         0         0            0            0            0        0       0       1          18019
 3885         0  Good day to you Nogg! I require training.  Good day to you Nogg! I require training.         0         0         0            0            0            0        0       0       1          18019
 4405         0  Salutations, Astarii. I require training.  Salutations, Astarii. I require training.         0         0         0            0            0            0        0       0       1          18019
 6499         0  I require training.                        I require training.                               0         0         0            0            0            0        0       0       1          18019
 6501         0  I require training.                        I require training.                               0         0         0            0            0            0        0       0       1          18019
 6503         0  I require training.                        I require training.                               0         0         0            0            0            0        0       0       1          18019
 8335         0  I require training, Lumak.                 I require training, Lumak.                        0         0         0            0            0            0        0       0       1          18019
 8337         0  I require training, Grimnur.               I require training, Grimnur.                      0         0         0            0            0            0        0       0       1          18019
 8347         0  I require training, Zamja.                 I require training, Zamja.                        0         0         0            0            0            0        0       0       1          18019
 8349         0  I require training, Daryl.                 I require training, Daryl.                        0         0         0            0            0            0        0       0       1          18019
 8365         0  I require training, Arnok.                 I require training, Arnok.                        0         0         0            0            0            0        0       0       0          18019
 8369         0  I require training, Nissa.                 I require training, Nissa.                        0         0         0            0            0            0        0       0       1          18019
31639         0  I require training, Highlord.              I require training, Highlord.                     0         0         0            0            0            0        0       0       1          18019
52088         0  I require training, Krenk.                 I require training, Krenk.                        0         0         0            0            0            0        0       0       1          18019

---

edit: BTW, gossip_menu_option contains fewer text lines like those than broadcast_text:

SELECT * FROM `gossip_menu_option` WHERE `option_text` LIKE '%I require training%';

menu_id      id  option_icon  option_text                    OptionBroadcastTextID  option_id  npc_option_npcflag  action_menu_id  action_poi_id  box_coded  box_money  box_text  BoxBroadcastTextID  VerifiedBuild
-------  ------  -----------  -----------------------------  ---------------------  ---------  ------------------  --------------  -------------  ---------  ---------  --------  ------------------  -------------
   4762       0            3  I require training, Nissa.                      8369          5                  16               0              0          0          0                             0              0
   3201       0            3  I require training.                             6503          5                  16               0              0          0          0                             0              0
   4742       0            3  I require training, Grimnur.                    8337          5                  16               0              0          0          0                             0              0
   4761       0            3  I require training, Arnok.                      8365          5                  16               0              0          0          0                             0              0
   4741       0            3  I require training, Lumak.                      8335          5                  16               0              0          0          0                             0              0
   4747       0            3  I require training, Zamja.                      8347          5                  16               0              0          0          0                             0              0
  10027       0            3  I require training, Highlord.                  31639          5                  16               0              0          0          0                             0              0

Unless someone can find a sniff telling us what the correct gossip_menu_id is for Byancie, we could use the gossip_menu_option without a name in it:

UPDATE `creature_template` SET `gossip_menu_id`= 3201 WHERE `entry`= 6094;

---

edit 2: D'oh, she is still available on retail servers, so it is still possible to sniff that info. Just have to wait for WPP to become updated to 7.x to enable parsing of the sniff.

---

edit 3: Bah. Byancie does not have gossip on 7.x retail, trainer UI only. So much for that idea.

BTW, shouldn't the npc_text "The esteemed Doctor Gustaf VanHowzen can train you further. He can be found in Theramore treating the wounded at the barracks." only be displayed when player has reached max First Aid skill at player level 35?

[MrSmite]

Unless someone can find a sniff telling us what the correct gossip_menu_id is for Byancie, we could use the gossip_menu_option without a name in it:

That's probably the easiest fix.

I wonder, is it possible to use a wildcard that tells the core to insert the NPC name? Similar to how we use $N for character name, we could use $NPC.

Also, yes. The trainers should direct you to the next one only if you're maxed out for what they offer.

[ghost]

I would think that this can be solved by using SAI + conditions to make sure that the NPC only shows npc_text 7026 when level 35 + max skill for Byancie's training is reached, but I don't think we need a gossip_menu_option for that gossip. I think Byancie should not show any gossip at all before max skill + level 35 is reached, only the trainer UI. I checked wowhead, wow.gamepedia and wowwiki as well as YouTube, but I could not find any info about her gossip text.