Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3.5] Spell/Rogue: Stealth is canceled by some friendly spells #18421

Closed
djbarrueco opened this issue Dec 6, 2016 · 2 comments
Closed

[3.3.5] Spell/Rogue: Stealth is canceled by some friendly spells #18421

djbarrueco opened this issue Dec 6, 2016 · 2 comments

Comments

@djbarrueco
Copy link

djbarrueco commented Dec 6, 2016

Description:
I found two spells that cancel stealth without having entered into combat and should not, maybe there are more.
1- Heroism/Bloodlust (Shaman)
2- Turn the Tables (Rogue).

Current behaviour:
Stealth is canceled by Heroism/Bloodlust and Turn the Tables.

Expected behaviour:
Stealth should not be canceled by Heroism/Bloodlust and Turn the Tables.

Steps to reproduce the problem:

  1. With a rogue in your party or raid use stealth.
  2. Cast Heroism/Bloodlust or anyone in your party or raid blocks, dodges, or parries an attack to activate Turn the Tables.
  3. Stealth is canceled without having entered into combat.

Branch(es): 3.3.5

TC rev. hash/commit: 3d5c1b8

TDB version: TDB_full_world_335.62_2016_10_17 + updates

Operating system: Windows

@lostsoul123
Copy link

lostsoul123 commented Dec 26, 2016

DELETE FROM `spell_custom_attr` WHERE `entry` IN(32182,2825,52910,52914,52915);
INSERT INTO `spell_custom_attr` (`entry`, `attributes`) VALUES
(32182, 64),
(2825 , 64),
(52910, 64),
(52914, 64),
(52915, 64);

@ariel- ariel- self-assigned this Dec 29, 2016
@shenhuyong
Copy link

@lostsoul123 It fixed Turn the Tables, but Heroism and Bloodlust still breaks stealth, SPELL_ATTR0_CU_DONT_BREAK_STEALTH be used to check break stealth attr only in SpellAuras.cpp Aura::GetProcEffectMask

ariel- added a commit that referenced this issue Dec 29, 2016
- They have damage class melee and proc PROC_FLAG_TAKEN_SPELL_MELEE_DMG_CLASS
- Sated/Exhaustion are negative auras, counts as negative spell flag, and stealth drops too

Closes #18421
Closes #18553
Aokromes pushed a commit to Aokromes/TrinityCore that referenced this issue Dec 30, 2016
- They have damage class melee and proc PROC_FLAG_TAKEN_SPELL_MELEE_DMG_CLASS
- Sated/Exhaustion are negative auras, counts as negative spell flag, and stealth drops too

Closes TrinityCore#18421
Closes TrinityCore#18553
joschiwald pushed a commit that referenced this issue Apr 29, 2018
- They have damage class melee and proc PROC_FLAG_TAKEN_SPELL_MELEE_DMG_CLASS
- Sated/Exhaustion are negative auras, counts as negative spell flag, and stealth drops too

Closes #18421
Closes #18553

(cherry picked from commit a39ccee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants