[3.3.5] Honor among thieves breaks stealth

[VincentVanclef]

Description: If i use rupture on a target and go stealth, when rupture crits it breaks stealth, only on crits. same happends on honor among thieves procs.

Current behaviour: (Tell us what happens.) ^

Expected behaviour: (Tell us what should happen instead.) Neither rupture crits nor honor should break stealth.

Steps to reproduce the problem:

1. get combo points
2. apply rupture to any npc
3. vanish and notice when it crits you destealth if you have honor among thieves in talents

Branch(es): 3.3.5 / master (Tell us which branch(es) this issue affects.)

TC rev. hash/commit: dbd5677

TDB version: 65

Operating system: unbuntu 16.04

[VincentVanclef]

added these values in spell_custom_atr and it fixed it:

51698 64
51699 64
51700 64
51701 64
52916 64
1943 64

[djbarrueco]

Maybe the same problem in #18421

[VincentVanclef]

yeah try add those abilities into the spell_custom_Atr like i did and test should fix it

[lmdelval]

@persephone can you email me to delvalmorell8606@gmail.com with a brief explanation about spell proc system, masks, flags... please? ^^

[VincentVanclef]

@Dalgurakk I dont know much about it, just that attribute 64 is "does not break sttealth"

[Keader]

@Dalgurakk look: #14824 (about this custom_attr)