Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Locales: Core doesn't care about player gender when sending gossip menu option locales #26261

Open
Aldoran2020 opened this issue Mar 17, 2021 · 5 comments

Comments

@Aldoran2020
Copy link

Aldoran2020 commented Mar 17, 2021

Description:

Explained in #26261 (comment)

Broadcast_text_locale esES ID: 50546

image

Expected behaviour:

Steps to reproduce the problem:

  1. speak with a guard with esES DB

Branch(es):

335

TC rev. hash/commit:

TrinityCore rev. 8c3cddd 2021-03-15 17:34:11 +0000 (3.3.5 branch) (Win64, RelWithDebInfo, Static) (worldserver-daemon)

Operating system:

windows pro

@offl
Copy link
Contributor

offl commented Mar 17, 2021

It looks like gossip option locale texts doesn't care about player gender(they should)
To avoid cases like in screenshot above, we need to take player gender in consideration when sending locale text
But it's not enough since we need to send male text (Text) only to male characters and female text (Text1) only to female characters because as you can see the difference between texts for male and female characters is not controlled only by $g

    ID  locale  Text                                              Text1                                               VerifiedBuild  
------  ------  ------------------------------------------------  --------------------------------------------------  ---------------
  7306  ruRU    Я готов к иллюзии, Миранда.                       Я готова к иллюзии, Миранда.                                  18019
Я готов к иллюзии, Миранда.
Я готова к иллюзии, Миранда.
готов 
готова 

    ID  locale  Text                                    Text1                                   VerifiedBuild  
------  ------  --------------------------------------  --------------------------------------  ---------------
  7306  esES    Estoy listo para la ilusión, Myranda.   Estoy lista para la ilusión, Myranda.             18019
Estoy listo para la ilusión, Myranda.
Estoy lista para la ilusión, Myranda.
listo
lista

However in this particular case I probably need to change broadcast text ids to more appropriate, this one is definitely for MoP - doesn't matter if I change them or not, all remaining with correct ids will be still broken

@Aokromes

This comment has been minimized.

@offl

This comment has been minimized.

@ghost

This comment has been minimized.

@offl offl changed the title DB/Locale/esES Rong text "3" Core/Locales: Core doesn't care about player gender when sending gossip menu option locales Mar 20, 2021
@offl
Copy link
Contributor

offl commented Mar 20, 2021

Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants