[3.3.5] Multiple lack of localization in the gossip menu

[Freeman256]

Description

I have come across a huge number of NPCs that do not work with the translation of options in gossip. For example, when I started completing quest The Hunt is On, I used the quest item Oculus of the Exorcist and started a conversation with the NPC I needed. The gossip menu option is not translated into Russian.

I began to figure out how it can be translated and climbed into the gossip_menu_option database and looked for the phrase "What do you know about the Cult of the Damned?" there and found it id - 9217. Then I created a new line in base gossip_menu_option_locale with the Russian version of this phrase:
INSERT INTO gossip_menu_option_locale (MenuID, Locale, OptionText) VALUES ('9217', 'ruRU', 'Что ты знаешь о Культе Проклятых?');
For some reason it didn't work. I noticed one more value in table gossip_menu_option: OptionBroadcastTextID - 25237.
Well, I decided to add a translation of this phrase to table broadcast_text_locale:
INSERT INTO broadcast_text_locale (ID, locale, Text, Text1) VALUES ('25237', 'ruRU', 'Что ты знаешь о Культе Проклятых?', 'Что ты знаешь о Культе Проклятых?');
But, all of a sudden, I got an error message:
/* SQL error (1062): Duplicate entry '25237-ruRU' for key 'PRIMARY' */

Then I used the filter and found that such a line really already exists, but despite this, for some reason it does not work. Then I tried creating a row in table gossip_menu_option_locale:
INSERT INTO gossip_menu_option_locale (MenuID, Locale, OptionText) VALUES ('25237', 'ruRU', 'Что ты знаешь о Культе Проклятых?');

But that didn't help either.

The crux of the problem: There should be a working ability to translate for the gossip menu options, and if possible, it should be easy to understand.

Expected behaviour

The gossip menus of NPCs should be translated into other languages. (It seems that I am the only one who, after a long time of downtime, took up the creation (or searching for a finished database) of Russian localization, so...)
OR
There must be a working way to translate them.

If this method exists, share your experience. The above described how I followed the logic, but I did not succeed, which means that not everything is good here. (If table gossip_menu_option_locale doesn't work, then what is it for?)

Steps to reproduce the problem

1. Launch the Russian version of the game (possibly with other languages);
2. Try talking to tavern owners around the world. If you need specifics, take quest The Hunt is On and start doing it. Talk to the NPCs you need and make sure there is no Russian translation of the gossip menu options;
3. Make sure the translation string exists in table broadcast_text_locale.

Branch

3.3.5

TC rev. hash/commit

8fcf59f
TrinityCore rev. 2021-08-07 ‏‎10:06:04 +0300 (3.3.5 branch) (Win64, Release, Static)

Operating system

Win7 SP1 x64 with all updates (build 6.1.7601).

Custom changes

None.

[offl]

If BroadcastText is NOT 0 in any table(creature_text, npc_text, gossip_menu_option), text is used from broadcast_text directly and locale text is taken directly from broadcast_text_locale
If BroadcastText is 0 in any table(creature_text, npc_text, gossip_menu_option), text is used from creature_text, npc_text, gossip_menu_option and locale text is used from creature_text_locale, npc_text_locale, gossip_menu_option_locale

Everything looks fine on DB side
All gossip option texts are not translated?

[Freeman256]

Not all. According to my observations, about half of the texts have been translated.

[offl]

Weird
Options of guards from #26261 too?

Do you have more examples? Like 2-3 working and 2-3 not working to compare them

[Freeman256]

The guards are all right.

Here are some examples. Everything is in order here:

And here there is no translation (see NPC ID in the chat window):

[Freeman256]

In addition, some profession teachers also do not have a translation (in this case, they are all in Teldrasilla, but I do not remember that at least one of the trainers I saw the translation in the upper part of the window):

[Freeman256]

If it is not possible to solve all such problems at once, then perhaps it is worth creating one general topic, such as this one #26727, and adding an NPC id with the missing localization of gossip options there?

[offl]

In addition, some profession teachers also do not have a translation (in this case, they are all in Teldrasilla, but I do not remember that at least one of the trainers I saw the translation in the upper part of the window):

trainer_locale, you can add them like in eac9851#diff-86f6d2b22c53377c4e50e646347ef668f8b50d6eeef6479c1f2014ecc3813a95R75

If it is not possible to solve all such problems at once, then perhaps it is worth creating one general topic, such as this one #26727, and adding an NPC id with the missing localization of gossip options there?

No, they already are translated, we need to figure out why it does not work in some cases

[offl]

Hol up, all those are innkeepers
#24961

Please try
.go c id 25248
He should have 2 gossip options and looks like first has no condition so is shown always
How does they look in game?

If one of options is not translated, execute

UPDATE `gossip_menu_option` SET `OptionType` = 1 WHERE `MenuID` = 9218 AND `OptionType` = 0;

.rel gossip_menu_option
And talk with creature again

[Freeman256]

This is how this NPC looked before the changes were made (the trade window opens immediately):

This is how this NPC looked after making edits, restarting the server and deleting the cache in the client:

Well, that is, yes, nothing has changed, and the trading window opens immediately.

[offl]

.go c id 25827

UPDATE `gossip_menu_option` SET `OptionType` = 1 WHERE `MenuID` = 9217 AND `OptionType` = 0;

.rel gossip_menu_option
And talk with creature again

[Freeman256]

UPDATE... and .rel gossip_menu_option didn't change anything. Restarting the server and deleting the cache in the client - no changes. Again, the trading window opens immediately.

It can be seen that this NPC is cutting meat. Maybe he should only sell meat? Not far from him is the innkeeper with untranslated text.

[offl]

Try #26785 (comment)

[Freeman256]

Nothing changed.

[offl]

Well, that is last chance

UPDATE `gossip_menu_option` SET `OptionNpcFlag` = 1 WHERE `MenuID` = 9217;