[Item] Tiny Abomination in a Jar is not proccing Seal of Vengeance

[Noonow]

The "mote of anger" proc from Tiny Abomination in a Jar should proc seal damage from Seal of Vengeance but it doesn't. It does proc seal damage when using Seal of Righteousness.
Tiny Abomination in a Jar is thé best ret trinket there in ICC is when properly working, now that it's not properly working it's not even 50% as good as it should be.

rev: 0ab9dd3

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Ric101]

Confirmed

[Xanvial]

confirmed
still doesn't work in eeb35df

i guess it's because in implementation of Seal of Vengeance/Corruption Unit.cpp

// spells with SPELL_DAMAGE_CLASS_MELEE excluding Judgements
bool damager = procSpell && procSpell->EquippedItemClass != -1;

but Manifest Anger (spell triggered by Tiny Abomination) has EquippedItemClass == -1

maybe change it to only exclude Judgement of Vengeance/Corruption spell id

[garyfisher]

Confirmed

Rev: cb8fc50

TDB: TDB 335.49+

[maxxx]

confirm

[Mercilessss]

Confirmed at bed7339

[garyfisher]

Confirmed!
Rev: 6e6ed50
TDB: TDB 335.51+

[Mercilessss]

467 melee crits
533 melee hits
999 SoV seal procs from auto attacks
1000 SoV stack refreshes
79 berserking procs from auto attacks

2,109.7 observed Motes of Anger

3,545 theoretical proc opportunities (assuming every crit provides 2x)
1772.5 expected Motes of Anger

Clearly we're getting more Motes of Anger than expected when using SoV. I think SoV seal crits (thus a 100% additional chance to refresh Vengeance) may be playing a role. For example, a 4x proc from a non crit without a Berserking proc:

[16:49:28.071] Pai's Vengeance is refreshed by Pai
[16:49:28.071] Pai hits Master's Training Dummy 1 (O: 1980)
[16:49:28.201] Master's Training Dummy's Holy Vengeance is refreshed by Pai
[16:49:28.201] Pai Seal of Vengeance Master's Training Dummy 1 (O: 2433) [# marks mean crit in WoL]
[16:49:28.625] Pai gains Mote of Anger (4) from Pai
[16:49:28.625] Pai gains Mote of Anger (5) from Pai
[16:49:28.625] Pai gains Mote of Anger (6) from Pai
[16:49:28.625] Pai gains Mote of Anger (7) from Pai

This may mean up to a 5x proc on melee crit + seal crit is possible (Vengeance refresh from melee crit, Vengeance refresh from seal crit, refreshing SoV stack, seal proc, melee attack). Blizzard's QA team really must be smoking something strong to allow something like this to go through.

Summary of valid proc sources:

Auto attack
Berserking auto attack proc
Holy Vengeance stack application/refresh
Auto attack or auto attack seal Vengeance application/refresh
Righteous Vengeance application/refresh
Auto attack Seal of Vengeance proc
Judgement debuff application/refresh
Yellow attack (J, CS, DS)

This will result in the following multipliers:

Melee hit: 2x (damage, Holy Vengeance)
Melee crit: 3x (damage, Holy Vengeance, Vengeance)
Berserking on auto attack: 1x
Auto attack SoV proc hit: 1x (damage)
Auto attack SoV proc crit: 2x (damage, Vengeance)
DS or CS hit: 1x (damage)
DS or CS crit: 2x (damage, Righteous Vengeance)
J hit: 2x (damage, debuff)
J crit: 3x (damage, debuff, Righteous Vengeance)

Source: Elitistjerks, tested on retail.

[Keader]

@ariel-