-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core/Spells] Dancing Rune Weapon #6192
Comments
is dbc problem ... #16281 << needs test. |
Is this fixing the diseases problem? Now the DRW reproduce the attack like IT and PS but doesn't apply the dot's! |
confirmed |
Fix (sorry, cannot did this as diff due to core differences): Unit.cpp: // Dancing Rune Weapon
if (dummySpell->Id == 49028)
{
// 1 dummy aura for dismiss rune blade
if (effIndex != 1)
return false;
Unit* pPet = NULL;
for (ControlList::const_iterator itr = m_Controlled.begin(); itr != m_Controlled.end(); ++itr) // Find Rune Weapon
if ((*itr)->GetEntry() == 27893)
{
pPet = *itr;
break;
}
// special abilities damage
if (pPet && pPet->getVictim() && damage && procSpell)
{
pPet->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NON_ATTACKABLE);
pPet->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NOT_SELECTABLE);
uint32 procDmg = damage / 2;
pPet->SendSpellNonMeleeDamageLog(pPet->getVictim(), procSpell->Id, procDmg, GetSpellSchoolMask(procSpell), 0, 0, false, 0, false);
pPet->DealDamage(pPet->getVictim(), procDmg, NULL, SPELL_DIRECT_DAMAGE, GetSpellSchoolMask(procSpell), procSpell, true);
break;
}
else // copy 50% melee damage
if (pPet && pPet->getVictim() && damage && !procSpell)
{
CalcDamageInfo damageInfo;
CalculateMeleeDamage(pPet->getVictim(), 0, &damageInfo, BASE_ATTACK);
damageInfo.attacker = pPet;
damageInfo.damage = damageInfo.damage / 2;
// Send log damage message to client
pPet->DealDamageMods(pPet->getVictim(),damageInfo.damage,&damageInfo.absorb);
pPet->SendAttackStateUpdate(&damageInfo);
pPet->ProcDamageAndSpell(damageInfo.target, damageInfo.procAttacker, damageInfo.procVictim, damageInfo.procEx, damageInfo.damage, damageInfo.attackType);
pPet->DealMeleeDamage(&damageInfo,true);
}
else
return false;
} SQL: INSERT INTO `spell_proc_event` (entry, procFlags) VALUES
('49028','69652'); Works like a charm (blizzlike). |
not working:) |
Very informative comment. Works on my server, did you replaced the code block? |
Yep. I mean, that diseases cast is not working. Also, DRW cast only blood strike ability |
SQL query should be applied too. |
Ofc, I apply query statement. Not working |
bump! |
This patch work for me when i aplied this patch and sql, but doesn't remove drw's autoatack (1-8dmg) so you must set unitflag pacified for creature rune weapon. |
On the serv I play, the resistance of the drw is ridiculous. Any aoe kill it. Is there a fix for this or you don't have this problem? |
You must set UNIT_FLAG_NON_ATTACKABLE in creature template for rune weapon. |
Pikalou, there is already in the patch: pPet->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NON_ATTACKABLE); |
oki thx ;-) |
any news? |
Only one issue that is left for me to fix is diseases(damage should be 50% od original diseases, And diseases stops do damage after rune is dismissed). |
Confirmed! |
you're probably using the wrong spells. |
Kaendra you don't say There isn't problem with wrong spell, Becouse for example frost fever (dmg: 0.32_lvl_1.15+ 0.055_AP_1.15) is correct spell for dk, and i don't find any spell with effect_0 that have 50% of effect_0 of dk's spell and the same name). Of course there is problem with aura system, that doesn't allow to deal damage without owner beeing present. |
And i'll be faster, for research i'm using spellwork. |
@nerv234 any research results? |
I have enough informations, but i need time, The only one thing to do is rewrite aura system to make it allow deal damage after disapearing owner(rune). |
confirm doesnt work rev: 2b88b49 |
It doesn't work yet at commit: |
Yes as you all know i can confirm still happens |
@mayaren888 |
Good evening. Need your help. I used a hack to fix a Rune Weapon. Now I can't paste the code in Unit.cpp. Can't find where to. Please tell me where to insert. Thanks in advance for your help. |
lul |
ccrs |
This is not a forum |
Regarding previous fix suggestions to this issue, note that TDB 335 no longer uses |
Any temporary fix? The ability does not work at all, is there any way to fix it, albeit not quite right? |
At the moment, I don't know of any other solution than the open PR Core/Spells: Dancing Rune Weapon #16281 |
There is no solution for several years. This is very bad. Even a workaround would be good. #16281 not working at the moment. Too many changes. |
Well, then we need someone with enough time and skills to write a new PR suggestion. |
@offl maybe we should open a new ticket for this isuue because no one worked on this lately maybe a new ticket ncourage to work on it. Its a core spell for blood dk and its important i think |
Dunno, that's not common practice here To encourage people a bounty can be added and priority label added if more people can agree this is high-priority issue |
Below may be not valid anymore, here's more fresh description of what is broken here #21538 + #25675
#6192 (comment) and in comments below
Abandoned PRs #16281 #23191
--
This spell was recently ( 24b699d ) fixed, but I am getting these log errors:
Using hash 4daafd0
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: