Arena frames

[Tiquihit]

When you use addons like Gladius and enter to an arena before your teammates, they appear in Gladius like they were your enemies. Also happens with blizzard arena frames.

Same problem --> http://code.google.com/p/trinitycore/issues/detail?id=582&sort=-id&colspec=ID%20Type

Regards!

Trinity rev. 2012-10-05 23:31:16 +0200 (ca55807+) (Unix, Release)

[Tiquihit]

http://i46.tinypic.com/2qu56hu.png Beginning of the arena. I entered after my partner.

[Xencha7]

Confirm.

[garyfisher]

Confirm!

Core: a664a35

TDB: TDB 335.49+

[Tiquihit]

any news? :D

[snehurka324]

Confirm d2ba73d

[frostmourne]

may be related to this
ddf494d

[garyfisher]

Confirm!

Core: 69377bc

TDB: TDB 335.49+

[alesete69]

Nothing more related to this topic?

[Tiquihit]

be patient :')

[saqirmdev]

Confirmed still bugged

[cover25]

Confirm on 4e22731+

[saqirmdev]

it is Critical, cause a big lags in arenas :-O still bugged

[Anthen]

Confirmed!

[xurxogr]

I managed to reproduce it (happensa to first member joining) but totally lost about the reason. Been checking the code and i don't find why it happens

[gpascualg]

As @lehtola (I'm not sure his github name is this) said yesterday on the IRC:
On the 4.3.4 branch there's a commit about fixing arenas. Reading it takes you here:

@@ -1212,6 +1233,9 @@ void Battleground::AddPlayer(Player* player)
             player->ResetAllPowers();
         }  

+        // Correctly display EnemyUnitFrame
+        player->SetByteValue(PLAYER_BYTES_3, 3, player->GetBGTeam());

         WorldPacket data(SMSG_ARENA_OPPONENT_UPDATE, 8);
         data << uint64(player->GetGUID());
         SendPacketToTeam(team, &data, player, false);

Which may indeed fix the arena frames. Can someone test on 3.3.5a and see if we can PR it?

[iconskater]

Still getting bugged

[lehtola]

You misunderstood me.
I'm talked about 172c5f0 this commit because it is totally shit. I didn't know why that guy just merged random commits withouts any tests or sniffs. Almost all wrong there.
So, all what you need it is send uiframe packet at the right time.

[tuxity]

@lehtola Stop troll please, It's all my work with help of other devs and it works, so if aren't agree please send us your work if you can do better. Btw 4.3.4 is in developpement, nothing finished yet.

[lehtola]

Man, srsly what are u talking about? If you can't understand that your changes in bgstatus packet and timer are wrong I dont know what you've forgotten here.
Actually why should I upload my fix? I'm not trinity developer, sorry. I simply pointed out a mistake. It is your choice to fix this shit or not. God, trinity have a lot of sniffs (Subv said about 5gb), use it!

[Shauren]

@lehtola with this attitude you can simply get the fuck out of here.

[iconskater]

it's not even working so stop this please. And get a real fix.

[lehtola]

@Shauren I have a great attitude to the Trinity.
But why should I develop code instead of the developers?
I asked for help, was refused, fixed phase bug after and share my fix. So, now I have no finished code because I'm not working on it.
Just pointed at mistake and was called troll, haha

[tuxity]

@lehtola "I'm talked about 172c5f0 this commit because it is totally shit. I didn't know why that guy just merged random commits withouts any tests or sniffs. Almost all wrong there. " This is pointing an error this ? Ok.

[gpascualg]

Aaam wow i just misunderstood him, I though he said it was working. There's no point in starting a flame war, it's not even related to the issue.
Sorry about this.

[sinakal]

bump..

any news from this?

this is really annoying..

[tuxity]

The opcode SMSG_ARENA_OPPONENT_UPDATE should be send at match start and not in AddPlayer()

[iconskater]

Thanks I'll add it and give the code here.

[tuxity]

diff please ?

[iconskater]

Removed here:

    if (isArena())
    {
        player->RemoveArenaEnchantments(TEMP_ENCHANTMENT_SLOT);
        if (team == ALLIANCE)                                // gold
        {
            if (player->GetTeam() == HORDE)
                player->CastSpell(player, SPELL_HORDE_GOLD_FLAG, true);
            else
                player->CastSpell(player, SPELL_ALLIANCE_GOLD_FLAG, true);
        }
        else                                                // green
        {
            if (player->GetTeam() == HORDE)
                player->CastSpell(player, SPELL_HORDE_GREEN_FLAG, true);
            else
                player->CastSpell(player, SPELL_ALLIANCE_GREEN_FLAG, true);
        }

        player->DestroyConjuredItems(true);
        player->UnsummonPetTemporaryIfAny();

        if (GetStatus() == STATUS_WAIT_JOIN)                 // not started yet
        {
            player->SetCommandStatusOn(CHEAT_CASTTIME);
            player->CastSpell(player, SPELL_ARENA_PREPARATION, true);
            player->ResetAllPowers();
        }
    REMOVED HERE
    WorldPacket data(SMSG_ARENA_OPPONENT_UPDATE, 8);
    data << uint64(player->GetGUID());
    SendPacketToTeam(team, &data, player, false);
    }
    else
    {
        if (GetStatus() == STATUS_WAIT_JOIN)                 // not started yet
            player->CastSpell(player, SPELL_PREPARATION, true);   // reduces all mana cost of spells.
    }

Added here:

     for (BattlegroundPlayerMap::const_iterator itr = GetPlayers().begin(); itr != GetPlayers().end(); ++itr)
            if (Player* player = ObjectAccessor::FindPlayer(itr->first))
            {
                ADDED HERE
                WorldPacket data(SMSG_ARENA_OPPONENT_UPDATE, 8);
                data << uint64(player->GetGUID());
                SendPacketToTeam(team, &data, player, false);
                // BG Status packet

[iconskater]

Even if you completly remove the code from here it still gets bugged

[tuxity]

I check with @spp and ... he's right, this opcode isn't really needed, but the place is good.

Maybe we have to add something like that:
player->SetByteValue(PLAYER_BYTES_3, 3, player->GetBGTeam());
as I've done in 4.3.4

As far as I remember, I've the same problem for ally players ( not sure)

[sinakal]

player->SetByteValue(PLAYER_BYTES_3, 3, player->GetBGTeam());

not helped.. its still bugged

[tuxity]

@iconskater no

[sinakal]

@tuxity

any news for this fix?

[digz6666]

Confirmed!

Revision: a7d8a65
Database: TDB.335.49 (with latest updates)

[Pumpush]

Confirmed!

[luciolis]

Confirmed.

[OPCODE187]

CONFIRMED!

[gereltod-g]

Still happening.

[saqirmdev]

Still bugged

[Array-0]

Confirmed!

Critical!!

[3kids]

http://i.imgur.com/mtkAo.jpg will fix it, only makes sense that way anyway imo
BattlegroundMgr.cpp

[digz6666]

@3kids Thanks for the fix, I will try :)

[hankxemn]

Works the fix?

[saqirmdev]

@3kids create a Gist plz

[garyfisher]

@saqirmdev https://github.com/garyfisher/GaryMoveOut/commit/542bd971ee6ebaf86d196f2f8d0d7621a5d691ce

[digz6666]

@kaelima Still not working, no custom patches applied.
@3kids Haven't tried the patch.

[snehurka324]

Confirmed,Not working
b138d7f

[digz6666]

Not working.
Revision: a05e78b

[eilwin]

Working partially on a261231
Now only pets bug the partner interface (owner interface works fine), and the rest it's fine

[digz6666]

Issue is back at revision: d1964f6

[magoxxx]

confirm, frame is bugged in rev: 26efbac

[FALL1N1]

Reopen this, confirm at: 5a6eacf