[Core/Spells] Target_Unit_Master #8643
Assignees
Comments
ghost
assigned
s7an-it
pushed a commit
that referenced
this issue
Dec 17, 2012
* cleanned a bit and edited old @treak fix, credits go to him, the quest will* work 100% blizzlike when target_unit_master #8643 gets a fix for vehicle. What concerns the quest is done. I've already fixed the core kill_credit issue, but needs to be discussed. * leaving the vehicle_AI until they get integrated correctly to SAI, this can be easily converted after. Currently need to make some hacks to make it work close to good if using SAI. (specificly terrain acts weird at that place) Closes: #5424
krofna
pushed a commit
to krofna/TrinityCore
that referenced
this issue
Dec 18, 2012
* cleanned a bit and edited old @treak fix, credits go to him, the quest will* work 100% blizzlike when target_unit_master TrinityCore#8643 gets a fix for vehicle. What concerns the quest is done. I've already fixed the core kill_credit issue, but needs to be discussed. * leaving the vehicle_AI until they get integrated correctly to SAI, this can be easily converted after. Currently need to make some hacks to make it work close to good if using SAI. (specificly terrain acts weird at that place) Closes: TrinityCore#5424
s7an-it
pushed a commit
that referenced
this issue
Dec 22, 2012
* what happened before was spells casted from vehicle to passenger getting blocked by general check exceptions that state passengers to be not implicitly spell hit, however they should be ignored when caster is vehicle to master passenger * fix a lot of quests that award kill credit that was blocked before * precisely closes: #8643 and makes #5254 awardable
raczman
pushed a commit
to raczman/TrinityCore
that referenced
this issue
Apr 20, 2014
* cleanned a bit and edited old @treak fix, credits go to him, the quest will* work 100% blizzlike when target_unit_master TrinityCore#8643 gets a fix for vehicle. What concerns the quest is done. I've already fixed the core kill_credit issue, but needs to be discussed. * leaving the vehicle_AI until they get integrated correctly to SAI, this can be easily converted after. Currently need to make some hacks to make it work close to good if using SAI. (specificly terrain acts weird at that place) Closes: TrinityCore#5424
raczman
pushed a commit
to raczman/TrinityCore
that referenced
this issue
Apr 20, 2014
* what happened before was spells casted from vehicle to passenger getting blocked by general check exceptions that state passengers to be not implicitly spell hit, however they should be ignored when caster is vehicle to master passenger * fix a lot of quests that award kill credit that was blocked before * precisely closes: TrinityCore#8643 and makes TrinityCore#5254 awardable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TARGET_UNIT_MASTER, not working when vehicle casts to controller while he is on him. These lines in the link without the parent condtiions were blocking it (only the parent condition is the added, don't have reg to highlight it). And here is the fix in spell.cpp. Putting it here, since can't multipull and want to clear my core a bit. This helps closing some issues over tracker, but can't track them. (all vehicle quests where vehicle award killcredit to master for example).
http://pastebin.com/kq3bVn3u
I don't know what exactly is the aurastate detection problem, but it comes from those 2 lines and can't change it and this breaks nothing since this a check for implicit targets. But I'm not sure, if this check is enough maybe some extra check can be tought out.
But the fix most likely is correct, because this check contraditcs with the state the controller gets as stated already, so they need exception here.
Solves kill credit for example of:
#5424 (and most likely 20/30+)
TDB: 11.49
OS: XP
Hash: 205cb06
The text was updated successfully, but these errors were encountered: