Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core/Spell: Some non-damage spells should break stealth #14765

Closed
wants to merge 1 commit into from
Closed

Core/Spell: Some non-damage spells should break stealth #14765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/server/game/Spells/SpellMgr.cpp
View file
Open in desktop
Expand Up @@ -2807,10 +2807,11 @@ void SpellMgr::LoadSpellInfoCustomAttributes()
case SPELL_AURA_AOE_CHARM:
case SPELL_AURA_MOD_FEAR:
case SPELL_AURA_MOD_STUN:
case SPELL_AURA_MOD_RESISTANCE_PCT: // Faerie fire
case SPELL_AURA_MOD_ROOT: // Roots
spellInfo->AttributesCu |= SPELL_ATTR0_CU_AURA_CC;
break;
case SPELL_AURA_PERIODIC_HEAL:
case SPELL_AURA_PERIODIC_DAMAGE:
case SPELL_AURA_PERIODIC_DAMAGE_PERCENT:
case SPELL_AURA_PERIODIC_LEECH:
case SPELL_AURA_PERIODIC_MANA_LEECH:
Expand All @@ -2821,6 +2822,10 @@ void SpellMgr::LoadSpellInfoCustomAttributes()
case SPELL_AURA_POWER_BURN:
spellInfo->AttributesCu |= SPELL_ATTR0_CU_NO_INITIAL_THREAT;
break;
case SPELL_AURA_PERIODIC_DAMAGE: // DoTs like Shadow Word: Pain
spellInfo->AttributesCu |= SPELL_ATTR0_CU_NO_INITIAL_THREAT;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whaaaaat

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean ? This flag is assigned on master, I did not make this up. I only added the SPELL_ATTR0_CU_AURA_CC flag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this code was on master (actually 3.3.5) the diff wouldn't show these added lines.

https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/SpellMgr.cpp#L2821

Please revert this change, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at this line on master:

https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/SpellMgr.cpp#L2813

In my commit I only moved the "case SPELL_AURA_PERIODIC_DAMAGE:" so I would be able to add the SPELL_ATTR0_CU_AURA_CC flag. I did not add / modify any other flags besides that flag (SPELL_ATTR0_CU_AURA_CC) compared to master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, I'm sorry.

spellInfo->AttributesCu |= SPELL_ATTR0_CU_AURA_CC;
break;
}

switch (spellInfo->Effects[j].Effect)
Expand Down