Core/LFG: Readd to queue if proposal denied #16279
Conversation
dmpaul26
changed the title
|
Please cleanup your commit history, squashing the 3 commits in 1 . |
| @@ -51,6 +51,7 @@ enum LfgUpdateType | |||
| LFG_UPDATETYPE_PROPOSAL_FAILED = 8, | |||
| LFG_UPDATETYPE_PROPOSAL_DECLINED = 9, | |||
| LFG_UPDATETYPE_GROUP_FOUND = 10, | |||
| LFG_UPDATETYPE_READDED_TO_QUEUE = 11, | |||
There was a problem hiding this comment.
Is this confirmed to have the value of 11?
There was a problem hiding this comment.
The client does not list this value explicitly - however sending anything other than 1, 6 and 10 makes it display "You have been readded to front" text
There was a problem hiding this comment.
there are a lot of client enums that do that
There was a problem hiding this comment.
I kinda went out on a limb, but it fit perfectly in the enum as if that was what was missing. The code functions without it, though.
|
Done. Struggled figuring out how to do it. |
Rushor
changed the title
|
Is this PR waiting for something else? |
|
Spp told me if you have any sniff where that type 11 is show. |
|
Thanks for looking into this. My fault, I thought I removed the type 11. I don't have a sniff for it. I took everything involving it out, should be good to go. |
|
Could you do one last change? Please rewrite the commit message - pull request title is not visible in commit log after merge |
|
Good point, done. Or, more descriptive? |
|
I assume something like "Core/LFG: Readd to queue if proposal denied" would be the trinitycore standard. But dont quote me on that. Great work 👍 |
|
Good point. When ever I write a commit message in GitExt, I make sure to use some form of category labeling like Core/LFG at the beginning (in most of my cases lately, it has been Core/Scripts) followed by a colon and a short and to-the-point title. I Prefer keeping it as close as possible to the PR title here in the issue tracker when I write the commit message. I also make sure to write a description 2 lines below (1 blank line between the commit title and the commit message content). I have seen some of the TC developers deviating from this form, but it depends on how well you want your commit described. |
Aokromes
changed the title
|
So is this just waiting on @dmpaul26 to update the name to something like "Core/LFG: Readd to queue if proposal denied" or what? |
|
@Saben65 no, its waiting for a TDB release (indirectly), more precisely for this TODO list to get smaller #15819 |
| @@ -117,7 +117,7 @@ std::string LFGQueue::GetDetailedMatchRoles(GuidList const& check) const | |||
| return o.str(); | |||
| } | |||
|
|
|||
| void LFGQueue::AddToQueue(ObjectGuid guid) | |||
| void LFGQueue::AddToQueue(ObjectGuid guid, bool reAdd) | |||
| { | |||
There was a problem hiding this comment.
AddToQueue(ObjectGuid guid, bool reAdd /*= false*/);
|
i think this is bugging the current system right now. allways 1 dps or 1 tank or 1 healer missing. (without using multiple roles) |
|
This PR couldn't really cause that, unless I misunderstood what you meant. |
|
Well, after someone denys the "entering dungeon" that happens. so i'm guessing this could be a possible cause. Not saying that actually is, just guessing. |
|
is possible you're trying to "readd" offline members? |
Fixed the issue where if a player declines to join a dungeon when matched, the rest of the matched players were added to the back of the queue. Players now return to the front of the queue.
Also should apply to 6.x
#14331