Core/Script: fix bug that prevent double spending reset cooldown #16287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @Vincent-Michael, @ShinDarth and @Rushor to be potential reviewers |
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (C) 2008-2016 TrinityCore <http://www.trinitycore.org/> | |||
| * Copyright (C) 2008-2015 TrinityCore <http://www.trinitycore.org/> | |||
|
that was annoying, Good Job! |
| @@ -14,17 +14,18 @@ | |||
| * You should have received a copy of the GNU General Public License along | |||
| * with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| */ | |||
|
|
|||
GigaDev90
force-pushed
the
fix_bug_duel_abuse
branch
from
1219ae8
to
6a2e7d8
Compare
|
|
||
| class DuelResetScript : public PlayerScript | ||
| { | ||
| public: | ||
| DuelResetScript() : PlayerScript("DuelResetScript") { } | ||
|
|
||
| typedef std::chrono::system_clock Clock; |
There was a problem hiding this comment.
you should just use SpellHistory::Clock instead of typedefing it here
GigaDev90
force-pushed
the
fix_bug_duel_abuse
branch
from
c3b2e42
to
c0ed819
Compare
FrancescoBorzi
added a commit
that referenced
this pull request
Jan 26, 2016
Core/Script: fix bug that prevent double spending reset cooldown
This was referenced Jan 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix, all spells cast 30 second before duel, it will not be restored