Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Scripts: Change door ID and name in Blackwing Lair #16327

Merged
merged 1 commit into from Jan 23, 2016
Merged

Core/Scripts: Change door ID and name in Blackwing Lair #16327

merged 1 commit into from Jan 23, 2016

Conversation

Exodius
Copy link
Contributor

@Exodius Exodius commented Jan 19, 2016

as per 7d454c6

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @joschiwald, @malcrom and @Rushor to be potential reviewers

@@ -59,7 +59,7 @@ enum CreatureIds
enum GameObjectIds
{
GO_BLACK_DRAGON_EGG = 177807,
GO_BOSSGATE01 = 175946,
GO_BOSSGATE01 = 176965,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update the name too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the correct name, please? Don't have the DB installed and, to be honest, I don't have enough drive space to re-install everything...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so maybe a name like GO_PORTCULLIS would be useful here.

@Exodius
Copy link
Contributor Author

Exodius commented Jan 19, 2016

@joschiwald, @MitchesD Edited and squashed. Is it OK like this?

@Exodius
Copy link
Contributor Author

Exodius commented Jan 19, 2016

Or should it be a bit flexible and be named GO_RAZORGORE_PORTCULLIS?

@Exodius Exodius changed the title Core/Scripts: Change door ID in Blackwing Lair Core/Scripts: Change door ID and name in Blackwing Lair Jan 19, 2016
@ghost
Copy link

ghost commented Jan 20, 2016

I think the name GO_PORTCULLIS is more flexible and that GO_RAZORGORE_PORTCULLIS is more specific.
But that is just my opinion. :)

MitchesD added a commit that referenced this pull request Jan 23, 2016
Core/Scripts: Change door ID and name in Blackwing Lair
@MitchesD MitchesD merged commit cb8faad into TrinityCore:3.3.5 Jan 23, 2016
@Exodius Exodius deleted the BWL-door branch January 24, 2016 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants