[3.3.5] Core/Spells: Fix Glyph of Arcane Shot #16622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @joschiwald, @Kandera and @Vincent-Michael to be potential reviewers |
|
|
||
| DELETE FROM `spell_script_names` WHERE `ScriptName` = 'spell_hun_glyph_of_arcane_shot'; | ||
| INSERT INTO `spell_script_names` (`spell_id`, `ScriptName`) VALUES | ||
| (56841,'spell_hun_glyph_of_arcane_shot'); |
|
|
||
| int32 mana = procSpell->CalcPowerCost(GetTarget(), procSpell->GetSchoolMask()); | ||
| int32 basepoint = CalculatePct(mana, aurEff->GetAmount()); | ||
| GetTarget()->CastCustomSpell(GetTarget(), SPELL_HUNTER_GLYPH_OF_ARCANE_SHOT, &basepoint, NULL, NULL, true, NULL, aurEff, GetCasterGUID()); |
There was a problem hiding this comment.
Some devs often complain about NULL
it is preferable to use nullptr
P-Kito
force-pushed
the
3.3.5
branch
2 times, most recently
from
402b706
to
67873d0
Compare
| @@ -0,0 +1,7 @@ | |||
| -- | |||
| DELETE FROM `spell_proc_event` WHERE `entry`= 56841; | |||
| INSERT INTO `spell_proc_event` VALUES (56841, 0, 9, 2048, 2048, 2048, 256, 0, 0, 0, 0); | |||
There was a problem hiding this comment.
hex looks better, and always add column names to insert querys
P-Kito
force-pushed
the
3.3.5
branch
2 times, most recently
from
58962d6
to
6eaf66c
Compare
|
All suggestions have been applied, ready for merge. 👍 |
|
there are some suggestions pending, you know |
|
who says? |
|
Ready for merge |
Shauren
added a commit
that referenced
this pull request
Feb 19, 2016
[3.3.5] Core/Spells: Fix Glyph of Arcane Shot
This was referenced Feb 19, 2016
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takeover of #16531 with recommended changes.
Closes #16500 and #16531
(Thanks to https://github.com/Eliminationzx)