Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [3.3.5] Core/Scripts: move npc_kharan_mighthammer to DB #17278

Closed
wants to merge 0 commits into from
Closed

[WIP] [3.3.5] Core/Scripts: move npc_kharan_mighthammer to DB #17278

wants to merge 0 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 4, 2016

Changes proposed:

Move scripts npc_kharan_mighthammer and npc_lokhtos_darkbargainer from core to DB & SAI

  • move hardcoded text from scripts to the gossip_menu_option table
  • remove core script and add SAI actions to complete gossip actions
  • add missing option texts for horde quest 4001 "What Is Going On?"
  • separate quest 4001 and 4342 dialog into horde / alliance sections

Target branch(es): 3.3.5

Issues addressed: Updates aletson#2

Tests performed: (Does it build, tested in-game, etc)
It builds (of course) because the only changes in the .cpp file is script removal.
Most of the gossip is still not working because some unknown issues with conditions or gossip tables.
Only the Alliance quest 4342 [Kharan's Tale] is working, not the Horde quest 4001.

Known issues and TODO list:

  • Fix dialogue for horde quest 4001 "What is going on (2)"

@ghost
Copy link
Author

ghost commented Jun 9, 2016

Sorry about the noise, I have restored my account and improved my account security now.

@ghost ghost reopened this Jun 9, 2016
@ghost ghost changed the title [WIP] [3.3.5] Core/Scripts: more cleanup in blackrock_depths.cpp [WIP] [3.3.5] Core/Scripts: move npc_kharan_mighthammer to DB Jul 6, 2016
@ghost ghost closed this Jul 6, 2016
@ghost ghost deleted the blackrock_depths_cleanup branch July 6, 2016 02:47
@ghost
Copy link
Author

ghost commented Jul 6, 2016

Messed up my branches. Will create a new PR when I have sorted out my stuff.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant