[WIP] [3.3.5] Core/Scripts: move npc_kharan_mighthammer to DB #17278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Move scripts
npc_kharan_mighthammer
andnpc_lokhtos_darkbargainer
from core to DB & SAIgossip_menu_option
tableTarget branch(es): 3.3.5
Issues addressed: Updates aletson#2
Tests performed: (Does it build, tested in-game, etc)
It builds (of course) because the only changes in the .cpp file is script removal.
Most of the gossip is still not working because some unknown issues with conditions or gossip tables.
Only the Alliance quest 4342 [Kharan's Tale] is working, not the Horde quest 4001.
Known issues and TODO list: