Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote #17374

ghost · 2016-06-15T03:21:54Z

Changes proposed:

Implement scripts for Mind Amplification Dish and Gnomish Universal Remote.
Based on the previous PR #16232 by @elecyb and feedback in that PR.

Adds functionality to the following items:

Mind Amplification Dish (enchant) - http://www.wowhead.com/spell=67839/mind-amplification-dish
Gnomish Thinking Cap - http://www.wowhead.com/item=48945/gnomish-thinking-cap
Gnomish Mind Control Cap - http://www.wowhead.com/item=10726/gnomish-mind-control-cap
Gnomish Universal Remote - http://www.wowhead.com/item=7506/gnomish-universal-remote

Chances are based on empirical results from wowhead (highly upvoted post):
http://www.wowhead.com/spell=67839/mind-amplification-dish#comments:id=1483300

> 65% of the time - Successful Mind Control.
> 30% of the time - Unsuccessful Mind Control.
<  5% of the time - Backfire

By elecyb & joschiwald

Target branch(es): 3.3.5 / 6.x

Issues addressed: Closes #2562

Tests performed: (Does it build, tested in-game, etc) Builds without issues.

Known issues and TODO list:

implement various suggested improvements

robens · 2016-06-15T09:06:24Z

src/server/scripts/Spells/spell_item.cpp

+        class spell_item_universal_remote_SpellScript : public SpellScript
+        {
+            PrepareSpellScript(spell_item_universal_remote_SpellScript);
+


load should also be overrided here with the same check of spell_item_mind_control_cap

OK, so you mean it should look like this:

class spell_item_universal_remote_SpellScript : public SpellScript { PrepareSpellScript(spell_item_universal_remote_SpellScript); bool Load() override { if (!GetCastItem()) return false; return true; } bool Validate(SpellInfo const* /*spellInfo*/) override {

Weird that joschiwald did not add it, he wrote the whole section below
// 8344 - Universal Remote (Gnomish Universal Remote)

yes, that's what I meant. You can wait for the original author if you feel like it.

I can add it, if you are as sure about this change as joschiwald is in his comments. ;-)

The probabilities of this being casted by a non-item is really low, but not 0. Joschiwald was focusing the roll chance management/spellinfo validation code with that comment.

If you want more insight about this, debug the castspell call and see if nullptr item is handled somewhere.

joschiwald · 2016-06-15T19:03:27Z

can you update the first spellscript similar to the second one?

ariel- · 2016-06-15T20:15:19Z

src/server/scripts/Spells/spell_item.cpp

+                });
+
+                if (Unit* target = GetHitUnit())
+                    GetCaster()->CastSpell(target, itr->second, true, GetCastItem());


itr->second is double, you probably mean itr->first here.

OK. Remember, this is elecyb's code, so I do what you suggest. :-)

ghost · 2016-06-15T20:58:20Z

(joschiwald) can you update the first spellscript similar to the second one?

Sure, I will do my best to make them similar in structure.

ghost · 2016-09-18T01:48:07Z

This branch has conflicts that must be resolved

Going to rebase this PR soon to fix those conflicts. Been occupied with other things, but will fix this soon.

SnapperRy · 2016-09-24T21:52:12Z

src/server/scripts/Spells/spell_item.cpp

+                return true;
+            }
+
+            void HandleDummy(SpellEffIndex /*effIndex*/)


I think this would be more fitting for the purpose:

if (Unit* target = GetHitUnit()) { uint8 chance = urand(0, 99); if (chance < 15) GetCaster()->CastSpell(target, SPELL_TARGET_LOCK, true, GetCastItem()); else if (chance < 35) GetCaster()->CastSpell(target, SPELL_MOBILITY_MALFUNCTION, true, GetCastItem()); else GetCaster()->CastSpell(target, SPELL_CONTROL_MACHINE, true, GetCastItem()); }

Instead of the unordered_map.

is more redable btw

OK, so that means I can remove

static std::unordered_map<uint32 /*spellId*/, double /*probability*/> const UniversalRemoteActions = { { SPELL_CONTROL_MACHINE, 60.0 }, { SPELL_MOBILITY_MALFUNCTION, 25.0 }, { SPELL_TARGET_LOCK, 15.0 } };

and replace that with enum instead. I will take a look at it as soon as I have done some other work.

enum UniversalRemote { CHANCE_TARGET_LOCK = 15, CHANCE_MOBILITY_MALFUNCTION = 25, SPELL_CONTROL_MACHINE = 8345, SPELL_MOBILITY_MALFUNCTION = 8346, SPELL_TARGET_LOCK = 8347 };

if (Unit* target = GetHitUnit()) { uint8 chance = urand(1, 100); if (chance <= CHANCE_TARGET_LOCK) GetCaster()->CastSpell(target, SPELL_TARGET_LOCK, true, GetCastItem()); else if (chance <= CHANCE_MOBILITY_MALFUNCTION) GetCaster()->CastSpell(target, SPELL_MOBILITY_MALFUNCTION, true, GetCastItem()); else GetCaster()->CastSpell(target, SPELL_CONTROL_MACHINE, true, GetCastItem()); }

Maybe I'm wrong but the % will change with this code
SPELL_TARGET_LOCK [1, 15] - 15%
SPELL_MOBILITY_MALFUNCTION [16, 25] - 10%
SPELL_CONTROL_MACHINE [26, 100] - 75%

GitVerge is right. SPELL_MOBILITY_MALFUNCTION should be changed to 35 instead of 25 :P

I think the correct number is 40 (15+25) and the other 60 for control machine

OK, maybe you're right. I don't know the calculation well enough to tell myself.
(mostly because I overtook the PR from another user to make it completable)

Implement scripts for Mind Amplification Dish and Gnomish Universal Remote Adds functionality to the following items: - Mind Amplification Dish (enchant) - Gnomish Thinking Cap - Gnomish Mind Control Cap - Gnomish Universal Remote By elecyb & joschiwald Closes #2562

…mote (#17374) (cherry picked from commit b651bf2) Rename 2016_09_09_20_world.sql to 2016_10_15_00_world.sql (cherry picked from commit d03b3e2)

Aokromes added Feedback-PatchFix Comp-C++Script labels Jun 15, 2016

robens reviewed Jun 15, 2016
View reviewed changes

ariel- reviewed Jun 15, 2016
View reviewed changes

Aokromes added Feedback-FixOutdatedMissingWIP and removed Feedback-PatchFix labels Jun 22, 2016

Aokromes added the Branch-3.3.5a label Jul 15, 2016

ghost changed the title ~~Core/Script: Gnomish Mind Control Cap and Gnomish Universal Remote~~ [WIP] Core/Script: Gnomish Mind Control Cap and Gnomish Universal Remote Aug 12, 2016

ghost changed the title ~~[WIP] Core/Script: Gnomish Mind Control Cap and Gnomish Universal Remote~~ [WIP] Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote Sep 24, 2016

ghost changed the title ~~[WIP] Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote~~ [WIP] [3.3.5] Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote Sep 24, 2016

ghost changed the title ~~[WIP] [3.3.5] Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote~~ [WIP] Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote Sep 24, 2016

SnapperRy reviewed Sep 24, 2016

View reviewed changes

elecyb and others added 2 commits October 15, 2016 01:23

Restore changes.

1ef6bf7

SnapperRy merged commit b651bf2 into TrinityCore:3.3.5 Oct 14, 2016

ghost changed the title ~~[WIP] Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote~~ Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote Oct 14, 2016

ghost added Feedback-PatchFix and removed Feedback-FixOutdatedMissingWIP labels Oct 14, 2016

ghost deleted the mind_control_cap_universal_remote branch October 15, 2016 00:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote #17374

Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote #17374

ghost commented Jun 15, 2016 •

edited by SnapperRy

Loading

robens Jun 15, 2016 •

edited

Loading

ghost Jun 15, 2016 •

edited by ghost

Loading

robens Jun 15, 2016

ghost Jun 15, 2016

robens Jun 15, 2016 •

edited

Loading

joschiwald Jun 15, 2016

joschiwald commented Jun 15, 2016

ariel- Jun 15, 2016

ghost Jun 15, 2016

ghost commented Jun 15, 2016

ghost commented Sep 18, 2016

SnapperRy Sep 24, 2016 •

edited by ghost

Loading

Keader Sep 24, 2016

ghost Sep 24, 2016 •

edited by ghost

Loading

robens Sep 29, 2016

SnapperRy Sep 29, 2016

robens Sep 29, 2016

ghost Sep 29, 2016

Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote #17374

Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote #17374

Conversation

ghost commented Jun 15, 2016 • edited by SnapperRy Loading

robens Jun 15, 2016 • edited Loading

Choose a reason for hiding this comment

ghost Jun 15, 2016 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robens Jun 15, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joschiwald commented Jun 15, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jun 15, 2016

ghost commented Sep 18, 2016

SnapperRy Sep 24, 2016 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost Sep 24, 2016 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jun 15, 2016 •

edited by SnapperRy

Loading

robens Jun 15, 2016 •

edited

Loading

ghost Jun 15, 2016 •

edited by ghost

Loading

robens Jun 15, 2016 •

edited

Loading

SnapperRy Sep 24, 2016 •

edited by ghost

Loading

ghost Sep 24, 2016 •

edited by ghost

Loading