Enabling Flight Masters #17781
Enabling Flight Masters #17781
Conversation
| @@ -128,7 +128,7 @@ void OpcodeTable::Initialize() | |||
| DEFINE_HANDLER(CMSG_ACCEPT_LEVEL_GRANT, STATUS_LOGGEDIN, PROCESS_THREADUNSAFE, &WorldSession::HandleAcceptGrantLevel); | |||
| DEFINE_HANDLER(CMSG_ACCEPT_TRADE, STATUS_LOGGEDIN, PROCESS_THREADUNSAFE, &WorldSession::HandleAcceptTradeOpcode); | |||
| DEFINE_HANDLER(CMSG_ACCEPT_WARGAME_INVITE, STATUS_UNHANDLED, PROCESS_INPLACE, &WorldSession::Handle_NULL); | |||
| DEFINE_HANDLER(CMSG_ACTIVATE_TAXI, STATUS_UNHANDLED, PROCESS_THREADSAFE, &WorldSession::HandleActivateTaxiOpcode); | |||
| DEFINE_HANDLER(CMSG_ACTIVATE_TAXI, STATUS_LOGGEDIN, PROCESS_THREADSAFE, &WorldSession::HandleActivateTaxiOpcode); | |||
There was a problem hiding this comment.
you need to confirm that structure did not change
There was a problem hiding this comment.
I updated the structure, didn't enable opcode because there are new fields that need to be handled.
There was a problem hiding this comment.
I know this is a newb question but how do I find the new fields so I can look at the changes and try to provide handlers for the new fields or did you already address the missing fields in commit 59cb674
|
Closing PR since it is not a fix and its a fixhack and not getting any feedback as to how to address what makes this a hack |
|
I'll look at this later this week, but if you still want to work on this PR, two new fields has been added : It's a new functionnality allowing player to travel on one of his mount, maybe only a favorite one, need to be determined. It should be handled before packet could be activated. You can gather data by sniffs, trying to get on travel with one of your mounts (seem like it's a random chance to me) |
|
@Traesh yes, client selects one random favorite mount for these fields but the catch here is that only one flight master uses this - the one in Dalaran on Broken Isles (probably there is a flag for this that needs to be researched) |
Changes proposed:
Target branch(es): 6.x
Issues addressed: Closes #17778
Tests performed: (Does it build, tested in-game, etc)
It builds with no warnings and has been tested by both campaigns
No crashes no issues and runs as it should
Known issues and TODO list:
I need to research how the flight paths work so maybe I can help address this