Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Scripts: move npc_saat to DB/SAI #17813

Merged
merged 1 commit into from Oct 15, 2016
Merged

Core/Scripts: move npc_saat to DB/SAI #17813

merged 1 commit into from Oct 15, 2016

Conversation

ghost
Copy link

@ghost ghost commented Aug 18, 2016

Changes proposed:

Remove the core script npc_saat and use DB data instead.
The core script only contains gossip handling + conditions:

  • remove script from file the_black_morass.cpp
  • thereby removing 1 line of hardcoded text
  • remove redundant SD2 comments in header
  • add SAI, gossip and conditions to DB

Target branch(es): 3.3.5 and 6.x

Issues addressed: No existing open issue related to Sa'at and the quest gossip in this dungeon.

Tests performed: (Does it build, tested in-game, etc)

  • Builds without any issue, core script removal.
  • Works as expected in-game, tested with a level 80 character.

Known issues and ToDo list:

  • The conditions for when to show the gossip options seem a bit unclear to me, because the player receives a Chrono-Beacon (item 24289) when accepting quest 10297 The Opening of the Dark Portal and should in theory not be presented with the option to ask for it before the quest is taken, but I am uncertain what the retail behaviour is for this gossip. Maybe @Killyana or @dr-j know more about it?

@Pixel-Pirate
Copy link

good job

@ghost ghost changed the title Core/Scripts: move npc_saat to DB Core/Scripts: move npc_saat to DB/SAI Aug 30, 2016
@Aokromes
Copy link
Member

What's missing here?

@ghost
Copy link
Author

ghost commented Oct 14, 2016

Nothing that I know of, when you compare the change to the original script.
Maybe there could be some improvement done to it, but I'm uncertain what that would be.

@Killyana
Copy link
Contributor

Conditions are not correct, also there's a missing text.
I will try to fix it.

The core script only contains gossip handling + conditions.
- remove script from file the_black_morass.cpp
- thereby removing 1 line of hardcoded text
- remove redundant SD2 comments in header
- add SAI, gossip and conditions to DB
@SnapperRy SnapperRy merged commit 028a7b8 into TrinityCore:3.3.5 Oct 15, 2016
@ghost ghost deleted the npc_saat branch October 15, 2016 00:23
Aokromes pushed a commit to Aokromes/TrinityCore that referenced this pull request Oct 24, 2016
The core script only contains gossip handling + conditions.
- remove script from file the_black_morass.cpp
- thereby removing 1 line of hardcoded text
- remove redundant SD2 comments in header
- add SAI, gossip and conditions to DB
joschiwald pushed a commit that referenced this pull request Oct 3, 2017
The core script only contains gossip handling + conditions.
- remove script from file the_black_morass.cpp
- thereby removing 1 line of hardcoded text
- remove redundant SD2 comments in header
- add SAI, gossip and conditions to DB
(cherry picked from commit 028a7b8)

Rename 2016_10_32_17813_world.sql to 2016_10_15_01_world.sql
(cherry picked from commit 13b748c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants