Core/Transport: always update position of non-static passengers

[SnapperRy]

Changes proposed:

Currently, the position of players inside transports is updated quite accurately when the transport is moving. However, this is not the case when the transport is not moving. Somehow, when the transport's waypoint movement is stopped, the player's position desyncs from the client.

The best way to check this is the quest Mutiny on the Mercy. On the ship's lower levels, there are hostile mobs. When the player is standing still or the ship is moving, they can attack and be attacked by the player just fine. But if the ship is standing still and the player moves, the mobs will reset and evade, unable to reach the player.

This fix greatly improves the behavior in such cases. I'm not sure if it's the proper way™ to fix it, but it's a start if anyone knows enough about the transport system to look into it.

Target branch(es): 3.3.5

Tests performed: tested and working.

[ghost]

Interesting solution. Will it have any positive effect on the NPCs on the airships in Icecrown? :-)

[SnapperRy]

I don't think it will affect them, as the Icecrown ships are always moving. I'm going to check anyway :P

[ghost]

OK, good point. I presume it won't be affecting that case, then. Thank you for checking it, though.

[SnapperRy]

Knight-Captain Drosche seems to get less stuck than before, but I'm not sure if it's due to this change or if it was already like that. I remember it being hard to talk with.

I'm not familiar with any other ship bugs, seems fine to me though :P