Core/Spells: Fixed some enchantments checks and fixed serious logic flaw in createitem effect check #19123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… item effect check
Shauren
reviewed
Feb 13, 2017
| if (!IsTriggered() && m_spellInfo->Effects[i].ItemType) | ||
| // m_targets.GetUnitTarget() means explicit cast, otherwise we dont check for possible equip error | ||
| Unit* target = m_targets.GetUnitTarget() ? m_targets.GetUnitTarget() : m_caster; | ||
| if (target && target->GetTypeId() == TYPEID_PLAYER && !IsTriggered() && m_spellInfo->Effects[i].ItemType) |
There was a problem hiding this comment.
if (target) is dead check, m_caster can never be NULL
There was a problem hiding this comment.
there should be no ? : m_caster, at all. Left it in case something else could depend on this check somehow (and thus the target check in case someone decides to remove it completely).
Aokromes
pushed a commit
to Aokromes/TrinityCore
that referenced
this pull request
Mar 13, 2017
…law in create item effect check (TrinityCore#19123)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch(es): 3.3.5
Tests performed: Compiles
As stated in title, any feedback is welcomed.