[WIP][3.3.5] Implement spawn group management in InstanceScript

[Treeston]

What it says on the tin - begin dynspawn follow-up work by gradually phasing out linked_respawn in favor of spawn groups for instance spawn control.

Medium term, once all instances have appropriate DB data, this will allow us to remove the instanceId column from the respawn tables altogether, relying exclusively on this system.

New DB table instance_spawn_groups:

• instanceMapId - duh
• bossStateId - duh
• bossStates - bitmask, 1 << state for EncounterState values
• flags - bitmask, currently allows 0x1 (FLAG_ACTIVATE_SPAWN) and 0x2 (FLAG_BLOCK_SPAWN)

A spawn group is activated if any of its FLAG_ACTIVATE_SPAWN conditions are met, unless any of its FLAG_BLOCK_SPAWN conditions are met - this allows for some neat complex management if necessary.

PS: Instance spawn data is currently being crowdsourced - check this thread.

[ghost]

/home/travis/build/TrinityCore/TrinityCore/src/server/game/Instances/InstanceScript.cpp:386:24:
 fatal error:
 comparison of integers of different signs: 'int8' (aka 'signed char') and 'size_type' (aka 'unsigned long') [-Wsign-compare]
    for (int8 i = 0; i < bosses.size(); ++i)
                     ~ ^ ~~~~~~~~~~~~~

[Treeston]

Yes, I am capable of reading travis output. Thank you.

[Shauren]

objection.
not this header.

[Treeston]

Hrm, just use the actual type (std::unordered_multimap< etc) instead of the typedef?

[Treeston]

Or no, that won't work either (type itself is defined in ObjectMgr.h). I'll think of something.

[Shauren]

I still don't like this, none of these headers should include each other (in any direction)
Proposed fix: change the container to std::unordered_map<uint16, std::vector<InstanceSpawnGroupInfo>>
and hold a pointer to that vector in InstanceScript

[Treeston]

Yeah, but where do we define InstanceSpawnGroupInfo? Class definitions need to be available at point of substitution, iirc?

[Shauren]

It doesn't matter. vector permits incomplete types

[Treeston]

Ah, great.

[Krudor]

Hell yes

[Keader]

@Treeston , @Ovahlord we need update the wiki with this table.

[ghost]

Oh right. I see. At least we need a new table name entry and the preliminary field names,
so others can fill in the necessary explanations based on the following SQL :

CREATE TABLE `instance_spawn_groups` (
  `instanceMapId` smallint(5) unsigned not null,
  `bossStateId` tinyint unsigned not null,
  `bossStates` tinyint unsigned not null,
  `spawnGroupId` int unsigned not null,
  `flags` tinyint unsigned not null,
  PRIMARY KEY (`instanceMapId`,`bossStateId`,`spawnGroupId`,`bossStates`)