Core/Spells: Fixed spell Health Funnel and Improved Health Funnel

[Keader]

Changes proposed:

• Fixed spell Health Funnel consuming 3 times more health that should.
• Fixed reduce of health using Health Funnel when warlock has Improved Health Funnel talent.

Issue:

Current script remove warlock health in 2 points.
Here: https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/Auras/SpellAuraEffects.cpp#L5941
And Here: https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/Auras/SpellAuras.cpp#L706
The second point, is called 2 times: First call is caused by Warlock Aura. The second is caused by Pet Aura.
And current script, dont check any SPELLMOD_COST, so reduce cost part of Improved Health Funnel not work.

Target branch(es): 3.3.5

Issues addressed: has no open issues.

Tests performed: Builded and tested in game

[Shauren]

What do you think about removing the health drop from PERIODIC_HEAL handler and only keeping the one in Aura::Update? The way I see it is SPELL_ATTR2_HEALTH_FUNNEL only changes the way health is removed - from raw ModifyHealth to DealDamage

[Keader]

You say something like: https://gist.github.com/Keader/ba483cbfae82c2a30393f78cba470c7c ?
Ps: m_owner == caster because AuraUpdate is called for both auras, Pet and Warlock

[Shauren]

Hmm, I did not expect this - caster != owner check breaks all auras with health cost that target anything other than caster but at the same time they are already broken in the same way as health funnel when targeting multiple units
Probably each spell cast should only be creating a single aura object for channeled spells with multiple applications (could also fix mind control DR)

[Keader]

@Shauren you will do it? because idk how do it

[Keader]

Maybe @ariel- can do it?