Game/AI: Implement option to move a creature back to Homeposition on Evade.

[Rushor]

…Evade.

• If ToHomePosition (action param 1) is 1 > Move to last stored position
• If ToHomePosition (action param 1) is 0 > Move to homeposition
• Ref: SAI/Movement: Evade after a waypoint #24226

Changes proposed:

• If ToHomePosition (action param 1) is 1 > Move to last stored position
• If ToHomePosition (action param 1) is 0 > Move to homeposition
• Ref: SAI/Movement: Evade after a waypoint #24226

Target branch(es): 3.3.5/master

• 3.3.5

Issues addressed: Closes # (insert issue tracker number)

#24226
Tests performed: (Does it build, tested in-game, etc.)
yes

Known issues and TODO list: (add/remove lines as needed)

• nothing
• [ ]

[Killyana]

Can you add an other param walk/run ?

[Rushor]

Why not adding it with the existing Action setwalk/run?

Should it run by default?

[Killyana]

Yes it must run by default, but as we will update existing SAI it's easier to just update the current line than adding an extra one for walk.

[Rushor]

okay cool, i will see if it is possible

[Rushor]

@Killyana added, if param walkmode 0 run by default

[Killyana]

I tested this issue #23917
The taunkas around Roanauk must evade to home position walking when the event ends.
But they just stay there:

UPDATE `smart_scripts` SET action_param1=0, action_param2=1 WHERE `entryorguid` IN( -102327,-102329,-102326,-102330,-102328,-102341,-102333) AND action_type=24;

[Rushor]

@Killyana okay i think the homeposition was not stored here - and name was wrong.

what we want: if paramter is 0 > move creature to the spawnposition.

what i changed:

if action_param1 (ToRespawnPosition) = 0, store new homeposition from respawnposition and move to it.

[Killyana]

It works fine now, thanks.
I need to some tests for other situations to be sure nothing get broken.

[Killyana]

Npcs always run on evade whatever the value of action_param2

[Rushor]

hm i cannot see the reason why they always run

[jackpoz]

hm i cannot see the reason why they always run

TrinityCore/src/server/game/Movement/MovementGenerators/HomeMovementGenerator.cpp

Line 79 in dc78566

init.SetWalk(false);

[jackpoz]

should the walk/run bit be ignored and merge the PR the way it is now ?

[ghost]

Could be a useful incentive to fix the mentioned walk/run issue if the current functionality becomes available to all. From what we have seen too often, testing does not take place until the code is published.

---

edit: I meant "committed/merged", remembering that "available to all" and "published" usually means "present on GitHub in any form" to most experienced coders.

[Rushor]

hm yeah then let's merge that "remove to home" fix first. i will remove the option with walk/run again.

or i must copy the function of GetMotionMaster()->MoveTargetedHome(); and define the

what would you suggest?

[Killyana]

In thins case make the npc return to home pos if there's no escort, and evades to the last point if it evades after a combat, no need to add an extra param

[jackpoz]

what's the status of this PR ?

[jackpoz]

jackpoz commented on Jun 6
what's the status of this PR ?

2nd try: what's the status of this PR ?

[ghost]

Hello, @Rushor . Thanks for the code to the "Force of Neltharaku" PR which is merged now.
I see you have been active about 2 days ago.
Everything OK, I hope?

[jackpoz]

Setting the status of this PR back to Draft as there are still some things left to do. Please mark it as ready for review once they have been handled.

[jackpoz]

Thanks for the PR :)