[CORE/SPELLS] Shaman Fire totems

[drskull]

Shaman Fire Totems have same spell crit like caster

Fix issue 3470

dr.skull@centrum.sk

[Aokromes]

I think also warlock, hunters and dk pets must be present here if they can't crit already, if they can't crit and they must crit a generic fix must be used.

[Vincent-Michael]

Hit for pets too

for crit: http://wowhead.com/spell=35695

Effect 0: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 0
Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)
Aura Id 57 (SPELL_AURA_MOD_SPELL_CRIT_CHANCE), value = 0, misc = 0 (0), miscB = 0, periodic = 0

Effect 1: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 1
Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)
Aura Id 52 (SPELL_AURA_MOD_WEAPON_CRIT_PERCENT), value = 1, misc = 0 (0), miscB = 0, periodic = 0

Effect 2: NO EFFECT

[drskull]

warlock, hunter, dk pets can crit already

[Vincent-Michael]

Example warlock pets spells crit with 1-2% crit

[drskull]

but Temporary Summons can't crit. Here are totems and Mage Water Elemental ...
Totems can crit, but can other Temp. summons crit ? If yes what chance they have ?

[Noth]

all pets, except totems, have a base 5% crit chance. they dont scale with players crit chance.
their crit only scales with talents/auras/sometimes procs.

[rsa]

all pets, except totems, have a base 5% crit chance. they dont scale with players crit chance.

your wrong, some (not all) pets has scaled from owner crit chance (over PSA). +adds from talents. classic example - mage water elemental.

[Noth]

pets do not scale with talents unless the tooltip explicitly says otherwise . they only scale with some auras, buffs, debuffs.
in cataclysm they scale with owner crit chance

[rsa]

not only in tooltips. i have measurements, maked for me in 3.3.5a, while i make PSS. result - some pets really scale crit chance (and some other parameters, like expertize) from owner. other auras only give additional crit chance.

[Midnights]

you have to clarify the usage of the word "pet"
temp summons indeed only got their 5% crit chance and DONT scale with owners crit chance/hit/exp etc
permanent pets like water elemental WITH glyph, hunter pets, ghoul with talent or warlock pets DO scale with base stats, crit, hit and expertise (where expertise is special, hunter pets e.g. are exp capped when the owner is hitcapped)

[rsa]

tempsummons with scaling - mage elemental (without glyph), shaman wolf's, druid triants. + some other (quests)

[Noth]

http://www.wowhead.com/forums&topic=119343/hunter-pet-crit
"Uhm... no?
Neither hunter crit rating, nor the value scale for pet. At least not directly. Only indirect pet scaling goes from this.

Basically:
5% base crit.
9% from this
10% from this if you are BM"

http://elitistjerks.com/f47/t20765-shaman_enhancement/#Feral_Spirit
there is nothing about crit chance scaling

http://rawr.codeplex.com/workitem/19785
the link is from cataclysm but it has 2 jpgs with treants hitting dummy and they do a wooping 1.7% crits. now if you factor in that on blizzard you have around ~4.3% crit reduction/depression when facing a lvl 83 target youll get exactly 5% pet crit chance.

[rsa]

you can read? about hunter pets nobody said anything, they have no suitable PSA. about crit rating feral spirit can still be read on wowhead. the same thing with the others.
however, the conversation bored. Do whatever you want, anyway the normal implementation of the pets in TC is impossible - all of their code heavy dirtied...

[Noth]

you can't read apparently
Midnights commented:
"...permanent pets like water elemental WITH glyph, hunter pets, ghoul with talent or warlock pets DO scale with base stats, CRIT..."
i wasnt replying only to you.

what ever, if you want to know how shit works look in the RAWR code for patch 3.3.5. its the most reliable imo because (almost) everything there was tested on blizzard servers.

[rsa]

I can not refute every delusion that meeting. in that message at least 2 errors and 2 inaccuracyes, I have only comment on one of the errors.

[Expecto]

fix work?

[drskull]

Need to find generic fix